-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore(all): Adjust dependabot settings #2056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I totally agree here with the suggested update. Same applies to Gradle plugin updates, like currently open bump to 8.1.0 - I don't think it makes sense to push that hard with only latest. In general, except for what you described I would suggest to bump some dependency version also in case there is some important fix (security or critical bug) introduced - I believe such cases worth it to bump minor versions as well.
I believe that we just missed those parts. Namely, it was me, who worked on this Dependabot config and I could forgot a few items worth watching. |
|
Ok cool. I also agree about the importance of manual updates if it's critical or necessary. How to proceed with the Gradle parts (so far unchanged in this PR)? |
Didn't get what you mean here |
|
The dependabot Gradle update policies remain unchanged in this PR. Should we add the same as for pub dependencies? |
Understood now. I would suggest to also make Gradle checks monthly as we really don't need to keep that on par with Android ecosystem in plugins. As to update types I would only drop patch updates as from experience minor releases in Android libraries are usually useful with fixes/new features. We can do it in another PR. P.S. A bit off-topic, but I have an itch to try and replace Dependabot with Renovate for some time already as it seems to me that we will have a better experience with configs/updates in Renovate. |
|
Good idea trying out another tool for dependency updates 👍🏽 |
Description
As partly discussed in this PR.
Related Issues
Our dependabot update policy continuously tightens the constraints, updating every single patch release - making the latest versions of plus_plugins less compatible with the rest of the ecosystem.
I'll just open this PR and leave it to discussion whether any included changes make sense for
plug_plugins.Following the changes plus my understanding of the benefit:
If a plugin declares a dependency x of
1.0.0, it's potentially compatible with version1.0.0up to<2.0.0and apps using the same dependency itself, or other packages using it (within the range>=1.0.0 <2.0.0). Updating to i.e.1.2.4tightens the constraints of all apps and packages using the plugin, making it less compatible with other packages, while bringing no benefit other than forcing users or other package maintainers to update their dependencies, which should not be our goal (unless there is an incompatibility with an older version, in which case the dependency should be manually updated to exclude lower versions).weeklytomonthly. Idk if the overhead of almost weekly updating a lint dependency for the website brings a benefit.Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).