Skip to content

Conversation

@vbuberen
Copy link
Collaborator

Description

Made the plugin use older js version as there were issues with compatibility for older Flutter versions as reported in #1960

Related Issues

Fixes #1960

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen vbuberen added the connectivity_plus Connectivity Plus label Jul 28, 2023
Copy link
Member

@nohli nohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

Since this repo is not an app, but packages, we could think about whether it makes sense to even update the patch version of a dependency beyond 0 - and tightening the constraints (which dependabot is doing right now).

For example, if it was js: ^0.6.0, users could get the latest version, but wouldn't be constrained to have minimum js: ^0.6.4.

@vbuberen
Copy link
Collaborator Author

Yes, I also believe that we can relax constraints a bit. Suggest to not make any special changes now, but for moving forward keep an eye on new available dependencies and evaluate if changes/fixes in any of them worths bumping the min version that we allow to use in plugins.

@vbuberen vbuberen merged commit 42938c0 into main Jul 28, 2023
@vbuberen vbuberen deleted the refactor/downgrade_js branch July 28, 2023 11:16
@nohli
Copy link
Member

nohli commented Jul 28, 2023

What do you think about ignoring patch releases in dependabot.yml?

If it's a version >= 1.0.0, ignoring minor bumps could also make sense.

@vbuberen
Copy link
Collaborator Author

Looks cool. Yes, might be indeed useful for plugins. Thanks for sharing.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

connectivity_plus Connectivity Plus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Connectivity Plus won't compile with flutter >=3.3.0

3 participants