Skip to content

[Gallery] Add padding to demo appBar #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2020
Merged

[Gallery] Add padding to demo appBar #289

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d13d2c
Add padding to demo appBar
guidezpl Jan 28, 2020
02f65a2
Update demo.dart
guidezpl Jan 28, 2020
443bc1f
Add padding to leading icon as well
guidezpl Jan 28, 2020
4324517
Update demo.dart
guidezpl Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions gallery/gallery/lib/pages/demo.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,15 +179,19 @@ class _DemoPageState extends State<DemoPage> with TickerProviderStateMixin {
final colorScheme = Theme.of(context).colorScheme;
final iconColor = colorScheme.onSurface;
final selectedIconColor = colorScheme.primary;
final appBarPadding = isDesktop ? 20.0 : 0.0;

final appBar = AppBar(
backgroundColor: Colors.transparent,
leading: IconButton(
icon: const BackButtonIcon(),
tooltip: MaterialLocalizations.of(context).backButtonTooltip,
onPressed: () {
Navigator.maybePop(context);
},
leading: Padding(
padding: EdgeInsetsDirectional.only(start: appBarPadding),
child: IconButton(
icon: const BackButtonIcon(),
tooltip: MaterialLocalizations.of(context).backButtonTooltip,
onPressed: () {
Navigator.maybePop(context);
},
),
),
actions: [
if (_hasOptions)
Expand Down Expand Up @@ -245,6 +249,7 @@ class _DemoPageState extends State<DemoPage> with TickerProviderStateMixin {
_state == _DemoState.fullscreen ? selectedIconColor : iconColor,
onPressed: () => _handleTap(_DemoState.fullscreen),
),
SizedBox(width: appBarPadding),
Copy link
Contributor

@rami-a rami-a Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would only solve the problem for the buttons on the right, but the back button on the left would still have the problem.

Copy link
Member Author

@guidezpl guidezpl Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hence the SizedBox on the left :)

Copy link
Member Author

@guidezpl guidezpl Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see what you mean

Copy link
Member Author

@guidezpl guidezpl Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the back button is already afforded enough space for the ripple to show

],
);

Expand Down