[Gallery] Add padding to demo appBar #289
Conversation
|
Also can you add a screenshot for how it looks like on mobile? |
| _state == _DemoState.fullscreen ? selectedIconColor : iconColor, | ||
| onPressed: () => _handleTap(_DemoState.fullscreen), | ||
| ), | ||
| SizedBox(width: appBarPadding), |
There was a problem hiding this comment.
This would only solve the problem for the buttons on the right, but the back button on the left would still have the problem.
There was a problem hiding this comment.
Hence the SizedBox on the left :)
There was a problem hiding this comment.
It looks like the back button is already afforded enough space for the ripple to show
This is the appBar for all demos, and sure! |
|
@guidezpl the issue is more evident in light theme but look at the ink ripple in the following screenshots
|
rami-a
left a comment
rami-a
left a comment
There was a problem hiding this comment.
LGTM with one small change
gallery/gallery/lib/pages/demo.dart
Outdated
| final colorScheme = Theme.of(context).colorScheme; | ||
| final iconColor = colorScheme.onSurface; | ||
| final selectedIconColor = colorScheme.primary; | ||
| final appBarPadding = 20.0; |
There was a problem hiding this comment.
Only do this if it is desktop, otherwise it'll look strange on mobile
This adds a bit of padding after the actions for the last ripple to be visible
Closes material-components/material-components-flutter-gallery#208