Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Nov 22, 2021

Precursor to #4533

On master channel, plugin unit tests must now build with SDK version 31.
These plugins are transitive dependencies of other plugins' examples,
which causes unit test failures in those plugins's unit test builds, so
these need to be landed and publish in order for that PR to pass
presubmit.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Precursor to flutter#4533

On master channel, plugin unit tests must now build with SDK version 31.
These plugins are transitive dependencies of other plugins' examples,
which causes unit test failures in those plugins's unit test builds, so
these need to be landed and publish in order for that PR to pass
presubmit.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 22, 2021
@stuartmorgan-g stuartmorgan-g changed the title Update some plugins targetSdkVersions to 31 Update some plugins' targetSdkVersions to 31 Nov 22, 2021
@stuartmorgan-g stuartmorgan-g mentioned this pull request Nov 22, 2021
11 tasks
@Hixie
Copy link
Contributor

Hixie commented Nov 22, 2021

test-exempt: fixes broken tests

@blasten
Copy link

blasten commented Nov 22, 2021

I think these issues are problematic. :/ The compileSdkVersion bump in the plugin is going to caused issues since most app users won't have plugins that use compileSdkVersion >= 31.

We will need to fix this in flutter.gradle.

@stuartmorgan-g
Copy link
Contributor Author

Landing on red as this is a partial fix to the tree redness.

@stuartmorgan-g stuartmorgan-g merged commit 16fa1ed into flutter:master Nov 22, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 22, 2021
@stuartmorgan-g stuartmorgan-g deleted the android-31-everywhere-publish-subset branch November 22, 2021 21:24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
Precursor to flutter#4533

On master channel, plugin unit tests must now build with SDK version 31.
These plugins are transitive dependencies of other plugins' examples,
which causes unit test failures in those plugins's unit test builds, so
these need to be landed and publish in order for that PR to pass
presubmit.
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Precursor to flutter#4533

On master channel, plugin unit tests must now build with SDK version 31.
These plugins are transitive dependencies of other plugins' examples,
which causes unit test failures in those plugins's unit test builds, so
these need to be landed and publish in order for that PR to pass
presubmit.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants