-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Update some plugins' targetSdkVersions to 31 #4535
Update some plugins' targetSdkVersions to 31 #4535
Conversation
Precursor to flutter#4533 On master channel, plugin unit tests must now build with SDK version 31. These plugins are transitive dependencies of other plugins' examples, which causes unit test failures in those plugins's unit test builds, so these need to be landed and publish in order for that PR to pass presubmit.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: fixes broken tests |
|
I think these issues are problematic. :/ The We will need to fix this in flutter.gradle. |
|
Landing on red as this is a partial fix to the tree redness. |
Precursor to flutter#4533 On master channel, plugin unit tests must now build with SDK version 31. These plugins are transitive dependencies of other plugins' examples, which causes unit test failures in those plugins's unit test builds, so these need to be landed and publish in order for that PR to pass presubmit.
Precursor to flutter#4533 On master channel, plugin unit tests must now build with SDK version 31. These plugins are transitive dependencies of other plugins' examples, which causes unit test failures in those plugins's unit test builds, so these need to be landed and publish in order for that PR to pass presubmit.
Precursor to #4533
On master channel, plugin unit tests must now build with SDK version 31.
These plugins are transitive dependencies of other plugins' examples,
which causes unit test failures in those plugins's unit test builds, so
these need to be landed and publish in order for that PR to pass
presubmit.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).