Update all targetSdkVersions #4533
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
p: android_alarm_manager
p: android_intent
p: battery
stuartmorgan-g
force-pushed
the
android-31-everywhere
branch
from
14e920f to
e4d8749
Compare
Nevermind, I see what's happening. This is indeed a publishing issue as you suggested, because the failure is in IAP; the IAP example uses shared_preferences. This won't go green in presubmit, but will be okay post-submit once I (manually) publish) Okay, the failures are:
|
|
I'm going to split out the ones that need to be published into a separate PR. That should be able to pass presubmit, and we can get it landed and then manually publish those while we figure out the dex issues for this PR. |
Precursor to flutter#4533 On master channel, plugin unit tests must now build with SDK version 31. These plugins are transitive dependencies of other plugins' examples, which causes unit test failures in those plugins's unit test builds, so these need to be landed and publish in order for that PR to pass presubmit.
|
Posted #4535 for the subset. Longer term, we should probably figure out if we can change the way our unit tests build somehow so that transitive dependencies of the example apps (which aren't actually involved in the unit test on Android AFAIK?) can't cause this kind of build failure... |
|
Precursor to #4533 On master channel, plugin unit tests must now build with SDK version 31. These plugins are transitive dependencies of other plugins' examples, which causes unit test failures in those plugins's unit test builds, so these need to be landed and publish in order for that PR to pass presubmit.
Thanks! I've pushed a version of the PR that updates the min deployment SDK version for the examples apps of the plugins that had issues, but it's not clear to me if that is all it needs, or we need to actually enable multidex in the plugin itself (which we definitely wouldn't want to do by changing the deployment SDK version). (I didn't have time to test locally as I need to head out for a while.) |
|
You can also use the |
…iew_flutter_android
|
Merging to fix the tree |
Precursor to flutter#4533 On master channel, plugin unit tests must now build with SDK version 31. These plugins are transitive dependencies of other plugins' examples, which causes unit test failures in those plugins's unit test builds, so these need to be landed and publish in order for that PR to pass presubmit.
Precursor to flutter#4533 On master channel, plugin unit tests must now build with SDK version 31. These plugins are transitive dependencies of other plugins' examples, which causes unit test failures in those plugins's unit test builds, so these need to be landed and publish in order for that PR to pass presubmit.
4 participants
Fixes compilation failures in unit tests on master.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.