-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[url_launcher] Re-remove Android API<24 support #9987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[url_launcher] Re-remove Android API<24 support #9987
Conversation
This re-lands the `url_launcher_android` portion of flutter#9851 which was reverted in flutter#9986 but with the missing min SDK update this time. Part of flutter/flutter#170807
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly re-implements the removal of support for Android API levels below 24 by updating the minSdkVersion and cleaning up related obsolete code. The changes are logical and well-contained. I've identified one minor issue in the CHANGELOG.md file regarding the formatting of a retracted version entry, which should be adjusted to align with the repository's style guide.
| * Updates minimum supported SDK version to Flutter 3.35. | ||
| * Removes obsolete code related to supporting SDK <24. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the repository's CHANGELOG style guide, when a version is retracted, the content should be replaced with a single bullet point explaining the retraction. The original change notes for the retracted version should be removed.1
Style Guide References
Footnotes
-
For a version that is retracted, the version header should be kept, but the content should be replaced with a single bullet point:
* **Retracted** for (reason).↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love that it added a footnote to try to make this hallucination sound more convincing.
bparrishMines
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/packages@03598e7...5db2635 2025-09-10 [email protected] [url_launcher] Re-remove Android API<24 support (flutter/packages#9987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#175232) flutter/packages@03598e7...5db2635 2025-09-10 [email protected] [url_launcher] Re-remove Android API<24 support (flutter/packages#9987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#175232) flutter/packages@03598e7...5db2635 2025-09-10 [email protected] [url_launcher] Re-remove Android API<24 support (flutter/packages#9987) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This re-lands the `url_launcher_android` portion of flutter#9851, which was reverted in flutter#9986, but with the missing min SDK update this time. Part of flutter/flutter#170807 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This re-lands the
url_launcher_androidportion of #9851, which was reverted in #9986, but with the missing min SDK update this time.Part of flutter/flutter#170807
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3