Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

The change to drop API 21-23 support was intended to set the minimum Flutter version to 3.35, but didn't actually do so. This reverts the changes to drop 21-23, so that anyone who got the broken version can update to a working version, and then I'll follow up with a new PR that re-lands the change but with the missed SDK constraint change.

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

The change to drop API 21-23 support was intended to set the minimum
Flutter version to 3.35, but didn't actually do so. This reverts the
changes to drop 21-23, so that anyone who got the broken version can
update to a working version, and then I'll follow up with a new PR that
re-lands the change but with the missed SDK constraint change.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g
Copy link
Collaborator Author

test-exempt: Revert, other than the version and changelog.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous change that dropped support for Android API levels 21-23, by setting minSdkVersion back to 21. The changes also re-introduce code to handle older API levels in WebViewActivity.java, specifically by adding back the deprecated shouldOverrideUrlLoading method for backward compatibility. My review focuses on ensuring the revert is complete and correct. I've found one area in WebViewActivity.java where the implementation for older APIs seems incomplete, which could lead to incorrect behavior on devices running Android API < 24. My suggestion addresses this to ensure consistent behavior across all supported API levels.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2025
@auto-submit auto-submit bot merged commit 03598e7 into flutter:main Sep 10, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 10, 2025
auto-submit bot pushed a commit that referenced this pull request Sep 10, 2025
This re-lands the `url_launcher_android` portion of #9851, which was reverted in #9986, but with the missing min SDK update this time.

Part of flutter/flutter#170807

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Sep 10, 2025
flutter/packages@2d651b2...03598e7

2025-09-10 [email protected] [url_launcher] Temporarily restore
Android 21 support (flutter/packages#9986)
2025-09-10 [email protected] Roll Flutter from
973320c to a082096 (17 revisions) (flutter/packages#9983)
2025-09-09 [email protected] [various] Scrub pre-Android-API <24
code (flutter/packages#9851)
2025-09-09 [email protected] [google_sign_in] Add a platform
interface method to clear auth tokens (flutter/packages#9929)
2025-09-09 [email protected] Revert "[url_launcher] fix: Link
widget Tab traversal" (flutter/packages#9980)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…r#175185)

flutter/packages@2d651b2...03598e7

2025-09-10 [email protected] [url_launcher] Temporarily restore
Android 21 support (flutter/packages#9986)
2025-09-10 [email protected] Roll Flutter from
973320c to a082096 (17 revisions) (flutter/packages#9983)
2025-09-09 [email protected] [various] Scrub pre-Android-API <24
code (flutter/packages#9851)
2025-09-09 [email protected] [google_sign_in] Add a platform
interface method to clear auth tokens (flutter/packages#9929)
2025-09-09 [email protected] Revert "[url_launcher] fix: Link
widget Tab traversal" (flutter/packages#9980)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
…r#175185)

flutter/packages@2d651b2...03598e7

2025-09-10 [email protected] [url_launcher] Temporarily restore
Android 21 support (flutter/packages#9986)
2025-09-10 [email protected] Roll Flutter from
973320c to a082096 (17 revisions) (flutter/packages#9983)
2025-09-09 [email protected] [various] Scrub pre-Android-API <24
code (flutter/packages#9851)
2025-09-09 [email protected] [google_sign_in] Add a platform
interface method to clear auth tokens (flutter/packages#9929)
2025-09-09 [email protected] Revert "[url_launcher] fix: Link
widget Tab traversal" (flutter/packages#9980)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
danferreira pushed a commit to danferreira/packages that referenced this pull request Oct 22, 2025
The change to drop API 21-23 support was intended to set the minimum Flutter version to 3.35, but didn't actually do so. This reverts the changes to drop 21-23, so that anyone who got the broken version can update to a working version, and then I'll follow up with a new PR that re-lands the change but with the missed SDK constraint change.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
danferreira pushed a commit to danferreira/packages that referenced this pull request Oct 22, 2025
This re-lands the `url_launcher_android` portion of flutter#9851, which was reverted in flutter#9986, but with the missing min SDK update this time.

Part of flutter/flutter#170807

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: url_launcher platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants