-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[url_launcher] Temporarily restore Android 21 support #9986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[url_launcher] Temporarily restore Android 21 support #9986
Conversation
The change to drop API 21-23 support was intended to set the minimum Flutter version to 3.35, but didn't actually do so. This reverts the changes to drop 21-23, so that anyone who got the broken version can update to a working version, and then I'll follow up with a new PR that re-lands the change but with the missed SDK constraint change.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: Revert, other than the version and changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a previous change that dropped support for Android API levels 21-23, by setting minSdkVersion back to 21. The changes also re-introduce code to handle older API levels in WebViewActivity.java, specifically by adding back the deprecated shouldOverrideUrlLoading method for backward compatibility. My review focuses on ensuring the revert is complete and correct. I've found one area in WebViewActivity.java where the implementation for older APIs seems incomplete, which could lead to incorrect behavior on devices running Android API < 24. My suggestion addresses this to ensure consistent behavior across all supported API levels.
bparrishMines
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This re-lands the `url_launcher_android` portion of #9851, which was reverted in #9986, but with the missing min SDK update this time. Part of flutter/flutter#170807 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
flutter/packages@2d651b2...03598e7 2025-09-10 [email protected] [url_launcher] Temporarily restore Android 21 support (flutter/packages#9986) 2025-09-10 [email protected] Roll Flutter from 973320c to a082096 (17 revisions) (flutter/packages#9983) 2025-09-09 [email protected] [various] Scrub pre-Android-API <24 code (flutter/packages#9851) 2025-09-09 [email protected] [google_sign_in] Add a platform interface method to clear auth tokens (flutter/packages#9929) 2025-09-09 [email protected] Revert "[url_launcher] fix: Link widget Tab traversal" (flutter/packages#9980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#175185) flutter/packages@2d651b2...03598e7 2025-09-10 [email protected] [url_launcher] Temporarily restore Android 21 support (flutter/packages#9986) 2025-09-10 [email protected] Roll Flutter from 973320c to a082096 (17 revisions) (flutter/packages#9983) 2025-09-09 [email protected] [various] Scrub pre-Android-API <24 code (flutter/packages#9851) 2025-09-09 [email protected] [google_sign_in] Add a platform interface method to clear auth tokens (flutter/packages#9929) 2025-09-09 [email protected] Revert "[url_launcher] fix: Link widget Tab traversal" (flutter/packages#9980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#175185) flutter/packages@2d651b2...03598e7 2025-09-10 [email protected] [url_launcher] Temporarily restore Android 21 support (flutter/packages#9986) 2025-09-10 [email protected] Roll Flutter from 973320c to a082096 (17 revisions) (flutter/packages#9983) 2025-09-09 [email protected] [various] Scrub pre-Android-API <24 code (flutter/packages#9851) 2025-09-09 [email protected] [google_sign_in] Add a platform interface method to clear auth tokens (flutter/packages#9929) 2025-09-09 [email protected] Revert "[url_launcher] fix: Link widget Tab traversal" (flutter/packages#9980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The change to drop API 21-23 support was intended to set the minimum Flutter version to 3.35, but didn't actually do so. This reverts the changes to drop 21-23, so that anyone who got the broken version can update to a working version, and then I'll follow up with a new PR that re-lands the change but with the missed SDK constraint change. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This re-lands the `url_launcher_android` portion of flutter#9851, which was reverted in flutter#9986, but with the missing min SDK update this time. Part of flutter/flutter#170807 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
The change to drop API 21-23 support was intended to set the minimum Flutter version to 3.35, but didn't actually do so. This reverts the changes to drop 21-23, so that anyone who got the broken version can update to a working version, and then I'll follow up with a new PR that re-lands the change but with the missed SDK constraint change.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3