Skip to content

Conversation

neilself
Copy link
Contributor

@neilself neilself commented Mar 5, 2025

Implementation package changes for PR 8573. This PR adds support for a new passthrough field to explicitly set an account name while signing in for Android devices.

Flutter issue: 163257

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

… account name. This capability is only available within Android for the underlying libraries.
…nstruction to test the account being constructed in the builder and then passed into GoogleSignInOptions. This is necessary as Account is an android class and cannot be instantiated normally in a unit test (the constructor will return null).
…due to platform interface changes in google_sign_in.
…e to platform interface changes in google_sign_in_platform_interface.
…ample due to platform interface changes in google_sign_in_platform_interface.
…sign_in_as_googleapis_auth for new change adding an optional account name field for Android sign-in.
@neilself neilself marked this pull request as ready for review March 5, 2025 22:39
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @camsim99 for second approval

@stuartmorgan-g stuartmorgan-g added the triage-android Should be looked at in Android triage label Mar 6, 2025
Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-g stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App and removed triage-android Should be looked at in Android triage labels Mar 6, 2025
@auto-submit auto-submit bot merged commit f5f9113 into flutter:main Mar 6, 2025
82 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 7, 2025
flutter/packages@fc9d5ca...4c5a7ed

2025-03-07 [email protected] Update PR template for clarity
(flutter/packages#8777)
2025-03-06 [email protected] [google_sign_in] Add Android account name
field as optional (implementation package changes)
(flutter/packages#8805)
2025-03-06 [email protected] Roll Flutter from
2578d97 to 321fbc0 (29 revisions) (flutter/packages#8808)
2025-03-06 [email protected] [various] Updates packages to use
flutter.compileSdkVersion (flutter/packages#8734)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
…tation package changes) (flutter#8805)

Implementation package changes for [PR 8573](flutter#8573). This PR adds support for a new passthrough field to explicitly set an account name while signing in for Android devices.

Flutter issue: [163257](flutter/flutter#163257)
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
…tation package changes) (flutter#8805)

Implementation package changes for [PR 8573](flutter#8573). This PR adds support for a new passthrough field to explicitly set an account name while signing in for Android devices.

Flutter issue: [163257](flutter/flutter#163257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants