Update PR template for clarity #8777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to make the PR checklist more clear about expectations: - Retitle the checklist to make it explicit that it's for review, not landing. - Make it explicit that the version, CHANGELOG, and test steps require some action, rather than just personally believing that a PR should be exempt.
|
I don't expect this to prevent PR submissions that don't follow the process of course, but hopefully it will cut down on legitimate confusion about what some of the steps mean, and reduce the number of comments we need to leave. |
tarrinneal
approved these changes
Mar 4, 2025
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/8777, because - The status or check suite Linux_android android_device_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/8777, because - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/8777, because - The status or check suite Linux_android android_device_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
|
autosubmit label was removed for flutter/packages/8777, because - The status or check suite Linux_android android_device_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 7, 2025
flutter/packages@fc9d5ca...4c5a7ed 2025-03-07 [email protected] Update PR template for clarity (flutter/packages#8777) 2025-03-06 [email protected] [google_sign_in] Add Android account name field as optional (implementation package changes) (flutter/packages#8805) 2025-03-06 [email protected] Roll Flutter from 2578d97 to 321fbc0 (29 revisions) (flutter/packages#8808) 2025-03-06 [email protected] [various] Updates packages to use flutter.compileSdkVersion (flutter/packages#8734) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
Attempt to make the PR checklist more clear about expectations: - Retitle the checklist to make it explicit that it's for review, not landing. - Make it explicit that the version, CHANGELOG, and test steps require some action, rather than just personally believing that a PR should be exempt.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
Attempt to make the PR checklist more clear about expectations: - Retitle the checklist to make it explicit that it's for review, not landing. - Make it explicit that the version, CHANGELOG, and test steps require some action, rather than just personally believing that a PR should be exempt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to make the PR checklist more clear about expectations: