Removing unnecessary parenthesis

[FMorschel]

This is simply removing unnecessary parenthesis from various places inside the packages. This change is because of a change to the unnecessary_parentesis lint that will trigger in these places. Here is the CL https://dart-review.googlesource.com/c/sdk/+/390161.

• [unnecessary_parenthesis] false negative in conditional operator dart-lang/sdk#57126

Pre-launch Checklist

• I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
• I read the [Tree Hygiene] page, which explains my responsibilities.
• I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the [CLA].
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I [linked to at least one issue that this PR fixes] in the description above.
• I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
• I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is [test-exempt].
• All existing and new tests are passing.

If anything else is needed please let me know.

I'd like to ask for this PR to wait a bit until the bots are run again on that CL so that I can be sure nothing else will trigger, I will come back here and update this whenever everything is complete. Thanks!

[cbracken]

The change in its current form LGTM, but you'll need to update the changelog.

[FMorschel]

The change in its current form LGTM, but you'll need to update the changelog.

Do I add the change to the closest CHANGELOG.md? There are a lot of examples changed here and no example folder has a changelog.

Or do I only need to add it to the cases where the change is outside the example folder?

[cbracken]

I've been working on Flutter nearly a decade and I'll be honest, until yesterday I didn't know either (evidence).

The example changes won't need anything, but CI is likely complaining about the following:

• https://github.com/flutter/packages/pull/7881/files#diff-0586de4d30521ddc85ce6b0c29ea52bbb41577fbd7f2cf4eb4d19e48d3f525cf
• https://github.com/flutter/packages/pull/7881/files#diff-87d9ef34a84045acf8bf73fd8313f590ac151fdf4afc4695fa6908e7f35d41cd

So I suspect bumping the patch version here:

• https://github.com/flutter/packages/blob/main/packages/pigeon/pubspec.yaml

and adding a changelog entry here:

• https://github.com/flutter/packages/blob/main/packages/pigeon/CHANGELOG.md

should be sufficient.

[cbracken]

Looks like this test needs fixing:

00:08 �[32m+294�[0m�[31m -1�[0m: test/version_test.dart: pigeon version matches pubspec �[1m�[31m[E]�[0m�[0m                                                                                                                              
  Expected: '22.5.1'
    Actual: '22.5.0'
     Which: is different.
            Expected: 22.5.1
              Actual: 22.5.0
                           ^
             Differ at offset 5
  
  package:matcher              expect
  test/version_test.dart 17:5  main.<fn>

Looking at this line in the pubspec.yaml, you'll want to update this line in generator_tools.dart.

[FMorschel]

Thanks. I had completely ignored that comment.

[stuartmorgan-g]

CHANGELOG/version override: While this technically changes some production code, the change is a no-op other than to silence a warning. (Technically the example/lib/main.dart changes should have a version change under our policy since they are published to pub.dev, but the change is trivial enough that we can just pick that up on the next publish event.)