[camera_android] Mark description in sendCameraErrorEvent as @NonNull
#7877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovschectman
requested review from
a team,
bparrishMines,
gmackall,
reidbaker and
stuartmorgan-g
yaakovschectman
added
override: no versioning needed
camsim99
approved these changes
Oct 16, 2024
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
This looks good to me!
If you think it's helpful, you could add more details about where the CameraAccessExceptions are being thrown in the error message like "CameraAccessException occurred when locking autofocus." but I don't feel strongly either way.
stuartmorgan-g
approved these changes
Oct 17, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM. I would also vote for adding some distinguishing text to the message, but the stack trace of the resulting Dart error should give context so it's not a big deal either way.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 17, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 17, 2024
flutter/packages@a35f02d...5582669 2024-10-17 [email protected] [two_dimensional_scrollables] Fixes TreeViewNode collapsing not working (flutter/packages#7474) 2024-10-17 [email protected] Revert "[in_app_purchase_storekit] Add support for purchase and transactions #7574" (flutter/packages#7886) 2024-10-17 [email protected] [camera_android] Mark `description` in `sendCameraErrorEvent` as `@NonNull` (flutter/packages#7877) 2024-10-17 [email protected] [image_picker_web] Loosen mime dep to >=1.0.4 <3.0.0 (flutter/packages#7879) 2024-10-17 [email protected] Removing unnecessary parenthesis (flutter/packages#7881) 2024-10-17 [email protected] [in_app_purchase_storekit] Add support for purchase and transactions #7574 (flutter/packages#7812) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendCameraErrorEventis package-visible and only called inCamera.javaandCameraTest.java. This should be test- and version-exempt, as it is essentially just an annotation change.Fixes flutter/flutter#156729
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.