[url_launcher] Remove incorrect SMS instructions #7807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes incorrect instructions for SMS that were added in flutter/plugins#6042. These instructions would double-encode the body, causing issues. This removes, rather than fixes, the instructions because the `sms:` scheme isn't particularly well defined, and has inconsistent handling across platforms (see flutter/flutter#18823 and flutter/flutter#156281 for some examples), so no simple instructions will work everywhere. Handling that kind of platform difference is out of scope for this package and its instructions. Fixes flutter/flutter#156281
ditman
approved these changes
Oct 7, 2024
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Yikes, thanks for cleaning this up!
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 8, 2024
flutter/packages@bb00d34...8fbf4cd 2024-10-08 [email protected] Manual roll Flutter from 0975e61 to ec2e12b (54 revisions) (flutter/packages#7815) 2024-10-08 [email protected] Manual roll Flutter from 6bba08c to 0975e61 (1 revision) (flutter/packages#7814) 2024-10-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.7 to 4.2.1 (flutter/packages#7813) 2024-10-08 [email protected] [interactive_media_ads] Adds remaining methods for internal wrapper of the iOS native `IMAAdsRenderingSettings` (flutter/packages#7745) 2024-10-08 [email protected] [url_launcher] Remove incorrect SMS instructions (flutter/packages#7807) 2024-10-08 [email protected] Manual roll Flutter from ead6b0d to 6bba08c (37 revisions) (flutter/packages#7809) 2024-10-07 [email protected] [webview_flutter_wkwebview] Support NTLM for authentication (flutter/packages#7670) 2024-10-07 [email protected] Revert "[in_app_purchase_storekit] Add support for purchase and transactions" (flutter/packages#7810) 2024-10-07 [email protected] [in_app_purchase_storekit] Add support for purchase and transactions (flutter/packages#7574) 2024-10-07 [email protected] Manual roll Flutter from fa402c8 to ead6b0d (14 revisions) (flutter/packages#7806) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes incorrect instructions for SMS that were added in flutter/plugins#6042. These instructions would double-encode the body, causing issues.
This removes, rather than fixes, the instructions because the
sms:scheme isn't particularly well defined, and has inconsistent handling across platforms (see flutter/flutter#18823 and flutter/flutter#156281 for some examples), so no simple instructions will work everywhere. Handling that kind of platform difference is out of scope for this package and its instructions.Fixes flutter/flutter#156281
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).