[in_app_purchase_storekit] Add support for purchase and transactions #7574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouiseHsu
changed the title
hellohuanlin
reviewed
Oct 2, 2024
| public var paymentQueueHandler: FLTPaymentQueueHandlerProtocol? | ||
|
|
||
| // This should be an Task, but Task is on available >= iOS 13 | ||
| var updateListenerTask: Any? |
Contributor
There was a problem hiding this comment.
can you try out that getter trick discussed yesterday?
packages/in_app_purchase/in_app_purchase_storekit/darwin/Classes/InAppPurchasePlugin.swift
Outdated
Show resolved
Hide resolved
..._app_purchase/in_app_purchase_storekit/darwin/Classes/StoreKit2/InAppPurchaseStoreKit2.swift
Outdated
Show resolved
Hide resolved
..._app_purchase/in_app_purchase_storekit/darwin/Classes/StoreKit2/InAppPurchaseStoreKit2.swift
Outdated
Show resolved
Hide resolved
| } | ||
| case .pending: | ||
| completion( | ||
| .failure( |
Contributor
There was a problem hiding this comment.
reduce indentation by combining these
Contributor
Author
There was a problem hiding this comment.
the formatter uncombines these
Contributor
There was a problem hiding this comment.
strange. it's clearly less than 100 characters. how's your code like before the formatter?
| @MainActor in | ||
| do { | ||
| let transactionsMsgs = await rawTransactions().map { | ||
| $0.convertToPigeon() |
Contributor
Author
There was a problem hiding this comment.
"Keypath can’t be used on instance methods"
..._app_purchase/in_app_purchase_storekit/darwin/Classes/StoreKit2/InAppPurchaseStoreKit2.swift
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /// Helper function to cast updateListenerTask to a task | ||
| func getUpdateListenerTask() -> Task<(), Never> { |
Contributor
There was a problem hiding this comment.
can you use a getter (rather than a function) in the class definition (rather than extension). And make updateListenerTask private.
..._purchase/in_app_purchase_storekit/example/shared/RunnerTests/StoreKit2TranslatorTests.swift
Outdated
Show resolved
Hide resolved
| @testable import in_app_purchase_storekit | ||
|
|
||
| @available(iOS 15.0, macOS 12.0, *) | ||
| class StoreKit2TranslatorTests: XCTestCase { |
hellohuanlin
approved these changes
Oct 2, 2024
Contributor
hellohuanlin
left a comment
hellohuanlin
left a comment
There was a problem hiding this comment.
LGTM after the nits
LouiseHsu
added
the
autosubmit
hellohuanlin
reviewed
Oct 7, 2024
| private var _updateListenerTask: Any? | ||
|
|
||
| @available(iOS 13.0, *) | ||
| var getListenerTaskAsTask: Task<(), Never> { |
Contributor
There was a problem hiding this comment.
You can change it in next PR - getter shouldn't have a get prefix. It should be just var updateListenerTask: Task<(), Never>
stuartmorgan-g
added a commit
that referenced
this pull request
Oct 7, 2024
…actions" (#7810) Reverts #7574 This is failing for `stable` (which only runs in post-submit). See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8734714858533469745/+/u/Run_package_tests/native_test/stdout for errors.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 8, 2024
flutter/packages@bb00d34...8fbf4cd 2024-10-08 [email protected] Manual roll Flutter from 0975e61 to ec2e12b (54 revisions) (flutter/packages#7815) 2024-10-08 [email protected] Manual roll Flutter from 6bba08c to 0975e61 (1 revision) (flutter/packages#7814) 2024-10-08 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.7 to 4.2.1 (flutter/packages#7813) 2024-10-08 [email protected] [interactive_media_ads] Adds remaining methods for internal wrapper of the iOS native `IMAAdsRenderingSettings` (flutter/packages#7745) 2024-10-08 [email protected] [url_launcher] Remove incorrect SMS instructions (flutter/packages#7807) 2024-10-08 [email protected] Manual roll Flutter from ead6b0d to 6bba08c (37 revisions) (flutter/packages#7809) 2024-10-07 [email protected] [webview_flutter_wkwebview] Support NTLM for authentication (flutter/packages#7670) 2024-10-07 [email protected] Revert "[in_app_purchase_storekit] Add support for purchase and transactions" (flutter/packages#7810) 2024-10-07 [email protected] [in_app_purchase_storekit] Add support for purchase and transactions (flutter/packages#7574) 2024-10-07 [email protected] Manual roll Flutter from fa402c8 to ead6b0d (14 revisions) (flutter/packages#7806) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
…7574 (#7812) This PR contains the preliminary implementations for handling [purchases](https://developer.apple.com/documentation/storekit/product/3791971-purchase) and [transactions](https://developer.apple.com/documentation/storekit/transaction) Of note, as of StoreKit 2, the [result of a call to a purchase will only return a Transaction](https://developer.apple.com/documentation/storekit/product/purchaseresult) when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned. This is in contrast to StoreKit 1, where developers could check the state of a Transaction with [TransactionState](https://developer.apple.com/documentation/storekit/skpaymenttransaction/1411275-transactionstate). This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly. Relands #7574
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
…actions #7574" (#7886) Reverts #7812 See #7812 (comment)
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
…7887) This PR contains the preliminary implementations for handling [purchases](https://developer.apple.com/documentation/storekit/product/3791971-purchase) and [transactions](https://developer.apple.com/documentation/storekit/transaction) Of note, as of StoreKit 2, the [result of a call to a purchase will only return a Transaction](https://developer.apple.com/documentation/storekit/product/purchaseresult) when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned. This is in contrast to StoreKit 1, where developers could check the state of a Transaction with [TransactionState](https://developer.apple.com/documentation/storekit/skpaymenttransaction/1411275-transactionstate). This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly. Relands #7574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the preliminary implementations for handling purchases and transactions
Of note, as of StoreKit 2, the result of a call to a purchase will only return a Transaction when the purchase is successful. If the status of purchase is pending, or cancelled, nothing will be returned.
This is in contrast to StoreKit 1, where developers could check the state of a Transaction with TransactionState. This means that migrating to StoreKit 2 will require developers to update their handling of transactions accordingly.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.