Skip to content

Conversation

@ditman
Copy link
Member

@ditman ditman commented Mar 27, 2024

Adds --allow-warnings to podspec_check_command.dart so stuff can keep rolling.

To be removed soon!

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Adds `--allow-warnings` to podspec_check_command.dart so stuff can keep rolling. To be removed soon!
@flutter-dashboard

This comment was marked as resolved.

@ditman ditman requested a review from jmagman March 27, 2024 22:49
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ditman
Copy link
Member Author

ditman commented Mar 27, 2024

Cleanup ticket created here:

@ditman
Copy link
Member Author

ditman commented Mar 27, 2024

Waiting to see the result of Mac_x64 check_podspecs, then applying autosubmit.

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 28, 2024
@auto-submit auto-submit bot merged commit e234425 into main Mar 28, 2024
@auto-submit auto-submit bot deleted the ditman-patch-2 branch March 28, 2024 02:18
@ditman
Copy link
Member Author

ditman commented Mar 28, 2024

Reason for revert: Failures happen (later) in other plugins (more updates in the related issue)

flutter/flutter#145866

@ditman ditman added the revert Label used to revert changes in a closed and merged pull request. label Mar 28, 2024
auto-submit bot pushed a commit that referenced this pull request Mar 28, 2024
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Mar 28, 2024
auto-submit bot added a commit that referenced this pull request Mar 28, 2024
#6416)" (#6419)

Reverts: #6416
Initiated by: ditman
Reason for reverting: Failures happen (later) in other plugins (more updates in the related issue)

flutter/flutter#145866
Original PR Author: ditman

Reviewed By: {jmagman}

This change reverts the following previous change:
Adds `--allow-warnings` to podspec_check_command.dart so stuff can keep rolling.

**To be removed soon!**
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 28, 2024
flutter/packages@e6b3e11...924c7e6

2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (#6416)" (flutter/packages#6419)
2024-03-28 [email protected] [ci] Temporarily allow-warnings in podspec_check_command.dart (flutter/packages#6416)
2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (#6060)" (flutter/packages#6417)
2024-03-27 [email protected] [interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter/packages#6060)
2024-03-27 [email protected] [camerax] Use `AspectRatioStrategy` to help automatic selection of expected resolution (flutter/packages#6357)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
philipfranchi pushed a commit to philipfranchi/flutter-relabel-widgets that referenced this pull request Mar 28, 2024
flutter/packages@e6b3e11...924c7e6

2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (flutter#6416)" (flutter/packages#6419)
2024-03-28 [email protected] [ci] Temporarily allow-warnings in podspec_check_command.dart (flutter/packages#6416)
2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter#6060)" (flutter/packages#6417)
2024-03-27 [email protected] [interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter/packages#6060)
2024-03-27 [email protected] [camerax] Use `AspectRatioStrategy` to help automatic selection of expected resolution (flutter/packages#6357)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants