[camerax] Use AspectRatioStrategy and ResolutionFilter to help automatic selection of expected resolution
#6357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
commented
Mar 19, 2024
| getProxyForTestingResolutionPreset(mockProcessCameraProvider); | ||
|
|
||
| when(mockProcessCameraProvider.bindToLifecycle(mockBackCameraSelector, any)) | ||
| when(mockProcessCameraProvider.bindToLifecycle(any, any)) |
Contributor
Author
There was a problem hiding this comment.
I removed similar testing of this particular call in a couple of tests in this PR and felt comfortable doing so because it is tested in other createCamera tests.
gmackall
approved these changes
Mar 20, 2024
packages/camera/camera_android_camerax/lib/src/camerax_proxy.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Gray Mackall <[email protected]>
camsim99
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages/6357, due to - The status or check suite Linux_android android_device_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
I was going to try to fix the linked issue in two PRs but tests are failing because I didn't implement a resolution filter for the one resolution preset that this PR does not address. Will work on implementing the filter and getting the tests to pass to avoid disabling/changing any tests. |
Contributor
Author
|
@gmackall if you are willing to take another look at this, I would greatly appreciate it! Overview of the new changes:
|
gmackall
approved these changes
Mar 26, 2024
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
I left some comments about documentation/a class name but LGTM outside that!
...id_camerax/android/src/main/java/io/flutter/plugins/camerax/ResolutionFilterHostApiImpl.java
Outdated
Show resolved
Hide resolved
| * <p>This class handles instantiating and adding native object instances that are attached to a | ||
| * Dart instance or handle method calls on the associated native class or an instance of the class. | ||
| */ | ||
| public class ResolutionFilterHostApiImpl implements ResolutionFilterHostApi { |
Member
There was a problem hiding this comment.
(I don't think this matters that much but just for my understanding) Isn't this more of a ResolutionFilterConstructor/FactoryHostApiImpl? Because we aren't wrapping the methods of the ResolutionFilter interface but rather of a class that defines and creates an instance of a ResolutionFilter?
Contributor
Author
There was a problem hiding this comment.
Ooo yes I like this, thank you! I will rename the proxy class it uses to clarify that this calls into a factory of sorts.
packages/camera/camera_android_camerax/lib/src/resolution_filter.dart
Outdated
Show resolved
Hide resolved
camsim99
added
the
autosubmit
camsim99
changed the title
AspectRatioStrategy to help automatic selection of expected resolutionAspectRatioStrategy and ResolutionFilter to help automatic selection of expected resolution
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2024
…on of expected resolution (flutter/packages#6357)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2024
…on of expected resolution (flutter/packages#6357)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 28, 2024
flutter/packages@e6b3e11...924c7e6 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (#6416)" (flutter/packages#6419) 2024-03-28 [email protected] [ci] Temporarily allow-warnings in podspec_check_command.dart (flutter/packages#6416) 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (#6060)" (flutter/packages#6417) 2024-03-27 [email protected] [interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter/packages#6060) 2024-03-27 [email protected] [camerax] Use `AspectRatioStrategy` to help automatic selection of expected resolution (flutter/packages#6357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
philipfranchi
pushed a commit
to philipfranchi/flutter-relabel-widgets
that referenced
this pull request
Mar 28, 2024
flutter/packages@e6b3e11...924c7e6 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ci] Temporarily allow-warnings in podspec_check_command.dart (flutter#6416)" (flutter/packages#6419) 2024-03-28 [email protected] [ci] Temporarily allow-warnings in podspec_check_command.dart (flutter/packages#6416) 2024-03-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter#6060)" (flutter/packages#6417) 2024-03-27 [email protected] [interactive_media_ads] Creates and adds the `interactive_media_ads` plugin (flutter/packages#6060) 2024-03-27 [email protected] [camerax] Use `AspectRatioStrategy` to help automatic selection of expected resolution (flutter/packages#6357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines
AspectRatioStategys that will help CameraX select the resolution we expect.Fixes flutter/flutter#144363.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).