Skip to content

[ci] Run 'flutter build --config-only for iOS and macOS during fetch deps #5804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2024
Merged

[ci] Run 'flutter build --config-only for iOS and macOS during fetch deps #5804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ca4ab0
Run 'flutter build --config-only for iOS and macOS during fetch deps
jmagman Jan 4, 2024
fc668c6
Merge branch 'main' into build-config-only
tarrinneal Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 6 additions & 37 deletions script/tool/lib/src/fetch_deps_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:file/file.dart';

import 'common/core.dart';
import 'common/gradle.dart';
import 'common/output_utils.dart';
Expand Down Expand Up @@ -216,44 +214,15 @@ class FetchDepsCommand extends PackageLoopingCommand {
}

for (final RepositoryPackage example in package.getExamples()) {
final Directory platformDir =
example.platformDirectory(getPlatformByName(platform));

// Running `pod install` requires `flutter pub get` or `flutter build` to
// have been run at some point to create the necessary native build files.
// See https://github.com/flutter/flutter/blob/fb7a763c640d247d090cbb373e4b3a0459ac171b/packages/flutter_tools/templates/cocoapods/Podfile-macos#L13-L15
// and https://github.com/flutter/flutter/blob/fb7a763c640d247d090cbb373e4b3a0459ac171b/packages/flutter_tools/templates/cocoapods/Podfile-ios-swift#L14-L16
final File generatedXCConfig = platform == platformMacOS
? platformDir
.childDirectory('Flutter')
.childDirectory('ephemeral')
.childFile('Flutter-Generated.xcconfig')
: platformDir
.childDirectory('Flutter')
.childFile('Generated.xcconfig');
if (!generatedXCConfig.existsSync()) {
final int exitCode = await processRunner.runAndStream(
flutterCommand,
<String>['pub', 'get'],
workingDir: example.directory,
);
if (exitCode != 0) {
printError('Unable to prepare native project files.');
return PackageResult.fail(<String>['Unable to configure project.']);
}
}

// Create the necessary native build files, which will run pub get and pod install if needed.
final int exitCode = await processRunner.runAndStream(
'pod',
<String>['install'],
workingDir: platformDir,
environment: <String, String>{
'LANG': 'en_US.UTF-8',
},
flutterCommand,
<String>['build', platform, '--config-only'],
workingDir: example.directory,
);
if (exitCode != 0) {
printError('Unable to "pod install"');
return PackageResult.fail(<String>['Unable to "pod install"']);
printError('Unable to prepare native project files.');
return PackageResult.fail(<String>['Unable to configure project.']);
}
}

Expand Down
Loading