Skip to content

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jan 4, 2024

For iOS and macOS move fetch deps from explicity running pub get and pod install to instead run flutter build x --config-only which smartly fetches deps and lays down the required native pieces. I didn't guard it on whether certain files are present since the command already has similar guards, and runs pretty fast if the native code has already been generated.

This fixes an issue where pod install is run before the Flutter native bits and migrations are run.

Fixes issues seen in the Flutter roll #5792 (comment)

Running command: "pod install" in /Volumes/Work/s/w/ir/x/w/packages/packages/camera/camera_avfoundation/example/ios
Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "Flutter":
  In Podfile:
    Flutter (from `Flutter`)

Specs satisfying the `Flutter (from `Flutter`)` dependency were found, but they required a higher minimum deployment target.

[!] Automatically assigning platform `iOS` with version `11.0` on target `Runner` because no platform was specified. Please specify a platform for this target in your Podfile. See `https://guides.cocoapods.org/syntax/podfile.html#platform`.
Unable to "pod install"

Caused by flutter/flutter#140478

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Jan 4, 2024
@jmagman jmagman marked this pull request as ready for review January 4, 2024 20:41
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm trying to remember why I didn't just do it this way in the first place. Probably I started from "I want to run pod install, and then worked backward to what minimal steps I needed to do to allow that.

@jmagman
Copy link
Member Author

jmagman commented Jan 4, 2024

I'm trying to remember why I didn't just do it this way in the first place.

Maybe predates macOS flutter/flutter#118649

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 5, 2024
@auto-submit auto-submit bot merged commit 0009545 into flutter:main Jan 5, 2024
@jmagman jmagman deleted the build-config-only branch January 5, 2024 01:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 5, 2024
flutter/packages@31fc7b5...b9b6d38

2024-01-05 [email protected] Manual roll Flutter from 11def8e to cc40425 (118 revisions) (flutter/packages#5806)
2024-01-05 [email protected] [ci] Run 'flutter build --config-only for iOS and macOS during fetch deps (flutter/packages#5804)
2024-01-05 [email protected] [image_picker] Remove input element after completion (flutter/packages#5654)
2024-01-05 [email protected] [video_player] Fix initial frame on macOS (flutter/packages#5781)
2024-01-05 [email protected] [pigeon] java non null void (flutter/packages#5786)
2024-01-04 [email protected] [file_selector_android] Attempt to close system dialogs before integration tests run (flutter/packages#5805)
2024-01-04 [email protected] [tool] Handle Flutter dev dependencies (flutter/packages#5775)
2024-01-04 [email protected] [url_launcher] Add `InAppBrowserConfiguration` parameter (flutter/packages#5758)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants