-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[ci] Run 'flutter build --config-only for iOS and macOS during fetch deps #5804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm trying to remember why I didn't just do it this way in the first place. Probably I started from "I want to run pod install
, and then worked backward to what minimal steps I needed to do to allow that.
Maybe predates macOS flutter/flutter#118649 |
flutter/packages@31fc7b5...b9b6d38 2024-01-05 [email protected] Manual roll Flutter from 11def8e to cc40425 (118 revisions) (flutter/packages#5806) 2024-01-05 [email protected] [ci] Run 'flutter build --config-only for iOS and macOS during fetch deps (flutter/packages#5804) 2024-01-05 [email protected] [image_picker] Remove input element after completion (flutter/packages#5654) 2024-01-05 [email protected] [video_player] Fix initial frame on macOS (flutter/packages#5781) 2024-01-05 [email protected] [pigeon] java non null void (flutter/packages#5786) 2024-01-04 [email protected] [file_selector_android] Attempt to close system dialogs before integration tests run (flutter/packages#5805) 2024-01-04 [email protected] [tool] Handle Flutter dev dependencies (flutter/packages#5775) 2024-01-04 [email protected] [url_launcher] Add `InAppBrowserConfiguration` parameter (flutter/packages#5758) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
For iOS and macOS move fetch deps from explicity running
pub get
andpod install
to instead runflutter build x --config-only
which smartly fetches deps and lays down the required native pieces. I didn't guard it on whether certain files are present since the command already has similar guards, and runs pretty fast if the native code has already been generated.This fixes an issue where
pod install
is run before the Flutter native bits and migrations are run.Fixes issues seen in the Flutter roll #5792 (comment)
Caused by flutter/flutter#140478
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.