[video_player_web] migrates to package:web #5800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ditman can you please review this |
Contributor
Author
|
@ditman can you please review this |
Contributor
|
Thanks @balvinderz ! |
p-mazhnik
reviewed
Jan 28, 2024
packages/video_player/video_player_web/lib/src/video_player.dart
Outdated
Show resolved
Hide resolved
Member
10 tasks
kevmoo
approved these changes
Mar 5, 2024
packages/video_player/video_player_web/example/integration_test/pkg_web_tweaks.dart
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_web/example/integration_test/video_player_test.dart
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_web/example/integration_test/video_player_test.dart
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_web/lib/video_player_web.dart
Outdated
Show resolved
Hide resolved
kevmoo
reviewed
Mar 5, 2024
* Adds factories for separate data/accessor Descriptors * Makes defineProperty a static method of 'Object', so it mirrors the JS API * Improves the `seekTo` test so it really throws from within the video object (throwy was not enough).
kevmoo
reviewed
Mar 6, 2024
packages/video_player/video_player_web/example/integration_test/pkg_web_tweaks.dart
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 6, 2024
flutter/packages@2aa6e3f...9b88dbc 2024-03-06 [email protected] [image_picker_for_web] migrates to package:web (flutter/packages#5799) 2024-03-06 [email protected] [video_player_web] migrates to package:web (flutter/packages#5800) 2024-03-06 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20240205 to 20240303 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#6253) 2024-03-05 [email protected] [rfw] Change test coverage logic to enforce 100% coverage (flutter/packages#6272) 2024-03-05 [email protected] [in_app_purchase_storekit] backfill native tests for more complete test coverage (flutter/packages#6209) 2024-03-05 [email protected] [tool] Add features to support GCB auto-publish flow (flutter/packages#6218) 2024-03-05 [email protected] [web] Use TrustedTypes from pkg web. (flutter/packages#6273) 2024-03-05 [email protected] Roll Flutter from 65cd84b to 3b5a2ec (26 revisions) (flutter/packages#6269) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/packages
that referenced
this pull request
Mar 7, 2024
Updates the web implementation of `video_player_web` to `package:web`. Also: prevents an infinite event loop when seeking to the end of a video after it's done. ### Issues * Fixes: flutter/flutter#139752 Co-authored-by: ToddZeil <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the web implementation of
video_player_webtopackage:web.Also: prevents an infinite event loop when seeking to the end of a video after it's done.
Issues
Co-authored-by: ToddZeil [email protected]
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.