[web] Use TrustedTypes from pkg web. #6273
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ditman
added
the
emergency
|
test-exempt: rolling dependency |
packages/google_maps_flutter/google_maps_flutter_web/lib/src/dom_window_extension.dart
Outdated
Show resolved
Hide resolved
|
Linux_web web_build_all_packages stable is a good canary for this issue (that's how I discovered it in an unrelated PR) |
I didn't realize this broke Flutter. :( It seems like it was because there were two extension members with the same name now? I think we should be more aggressive about releasing breaking change versions instead of minor versions when there are new members being added.
I think this wouldn't be caught because this bot isn't run when we publish package:web. I wonder if we can enable this bot for that package. |
@srujzs It didn't break Flutter, only some packages that wanted to use TrustedTypes before they were exposed by
This is totally my bad, I should have namespaced package:web |
flutter/packages@2aa6e3f...9b88dbc 2024-03-06 [email protected] [image_picker_for_web] migrates to package:web (flutter/packages#5799) 2024-03-06 [email protected] [video_player_web] migrates to package:web (flutter/packages#5800) 2024-03-06 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20240205 to 20240303 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#6253) 2024-03-05 [email protected] [rfw] Change test coverage logic to enforce 100% coverage (flutter/packages#6272) 2024-03-05 [email protected] [in_app_purchase_storekit] backfill native tests for more complete test coverage (flutter/packages#6209) 2024-03-05 [email protected] [tool] Add features to support GCB auto-publish flow (flutter/packages#6218) 2024-03-05 [email protected] [web] Use TrustedTypes from pkg web. (flutter/packages#6273) 2024-03-05 [email protected] Roll Flutter from 65cd84b to 3b5a2ec (26 revisions) (flutter/packages#6269) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
During the `package:web` migration, some packages that needed the TrustedTypes API defined those as custom JS-interop. In `google_identity_services_web`, the names of the JS-interop types clashed with those from the incoming package:web, breaking the build. In `google_maps_flutter_web`, the whole definition code is redundant now that the standard API is exposed through package:web. Part of: flutter/flutter#117022
5 participants
During the
package:webmigration, some packages that needed the TrustedTypes API defined those as custom JS-interop.In
google_identity_services_web, the names of the JS-interop types clashed with those from the incoming package:web, breaking the build.In
google_maps_flutter_web, the whole definition code is redundant now that the standard API is exposed through package:web.Part of: flutter/flutter#117022
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.