Skip to content

[pointer_interceptor] Mark PointerInterceptor as invisible #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 3, 2022
Merged

[pointer_interceptor] Mark PointerInterceptor as invisible #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abe9eb5
[pointer_interceptor] Mark `PointerInterceptor` as invisible
harryterkelsen Dec 4, 2021
96f5233
dartfmt
harryterkelsen Dec 4, 2021
3c4c7b2
Merge branch 'main' into pointerinterceptor-invisible
ditman Dec 14, 2021
5d61fb5
Merge branch 'main' into pointerinterceptor-invisible
ditman Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pointer_interceptor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.9.2

* Marked `PointerInterceptor` as invisible, so it can be optimized by the engine.

## 0.9.1

* Removed `android` and `ios` directories from `example`, as the example doesn't
Expand Down
3 changes: 2 additions & 1 deletion packages/pointer_interceptor/lib/src/shim/dart_ui_fake.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ class platformViewRegistry {
/// Shim for registerViewFactory
/// https://github.com/flutter/engine/blob/master/lib/web_ui/lib/ui.dart#L72
static void registerViewFactory(
String viewTypeId, dynamic Function(int viewId) viewFactory) {}
String viewTypeId, dynamic Function(int viewId) viewFactory,
{bool isVisible = true}) {}
}

// ignore: avoid_classes_with_only_static_members
Expand Down
2 changes: 1 addition & 1 deletion packages/pointer_interceptor/lib/src/web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ void _registerFactory({bool debug = false}) {
htmlElement.style.backgroundColor = 'rgba(255, 0, 0, .5)';
}
return htmlElement;
});
}, isVisible: false);
}

/// The web implementation of the `PointerInterceptor` widget.
Expand Down
2 changes: 1 addition & 1 deletion packages/pointer_interceptor/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: pointer_interceptor
description: A widget to prevent clicks from being swallowed by underlying HtmlElementViews on the web.
repository: https://github.com/flutter/packages/tree/main/packages/pointer_interceptor
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pointer_interceptor%22
version: 0.9.1
version: 0.9.2

environment:
sdk: ">=2.12.0 <3.0.0"
Expand Down