Skip to content

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Dec 4, 2021

Marks PointerInterceptor as invisible.

After flutter/engine#30003 invisible platform views incur no performance penalty, as they no longer need an overlay.

Fixes flutter/flutter#94641

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@godofredoc godofredoc changed the base branch from master to main December 13, 2021 22:18
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hterkelsen Can this land already, or do we need to wait for some specific flutter version to be published?

@stuartmorgan-g
Copy link
Collaborator

@hterkelsen What's the status here?

@ditman
Copy link
Member

ditman commented Jan 31, 2022

This and flutter/plugins#4578 are waiting for 2.10 to roll into stable.

@ditman ditman self-assigned this Jan 31, 2022
@ditman
Copy link
Member

ditman commented Feb 3, 2022

Updating this PR to land it.

@ditman
Copy link
Member

ditman commented Feb 3, 2022

All green, let's go!

@fluttergithubbot fluttergithubbot merged commit 0bcdbdf into flutter:main Feb 3, 2022
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[pointer_interceptor] Mark PointerInterceptor as invisible

4 participants