-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[pointer_interceptor] Mark PointerInterceptor as invisible
#529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pointer_interceptor] Mark PointerInterceptor as invisible
#529
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@hterkelsen Can this land already, or do we need to wait for some specific flutter version to be published?
|
@hterkelsen What's the status here? |
|
This and flutter/plugins#4578 are waiting for 2.10 to roll into |
|
Updating this PR to land it. |
|
All green, let's go! |
Marks
PointerInterceptoras invisible.After flutter/engine#30003 invisible platform views incur no performance penalty, as they no longer need an overlay.
Fixes flutter/flutter#94641
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.