Skip to content

[gis_web] Adds FedCM toggle. #5123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 17, 2023
Merged

[gis_web] Adds FedCM toggle. #5123

merged 6 commits into from
Oct 17, 2023

Conversation

@ditman
Copy link
Member

@ditman ditman commented Oct 12, 2023

This PR updates the IdConfiguration object of the Google Identity Services SDK with new values added since this was last updated.

The main change is adding use_fedcm_for_prompt so FedCM can be enabled on Flutter Web apps.

Issues

Pre-requirement for: flutter/flutter#133703

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from stuartmorgan-g October 12, 2023 01:38
@ditman ditman self-assigned this Oct 12, 2023
stuartmorgan-g
stuartmorgan-g requested changes Oct 12, 2023
View reviewed changes
packages/google_identity_services_web/lib/src/js_interop/google_accounts_id.dart
///
/// For more information, see:
/// * https://developers.google.com/identity/protocols/oauth2/openid-connect#authenticationuriparameters
String? login_hint,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ship has clearly already sailed on this, but out of curiosity why are we using snake case instead of camel case for all of these, given that it's Dart code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we using snake case instead of camel case for all of these, given that it's Dart code?

Originally, my idea was that it'd be easier for users to find documentation for the parameters if they were called exactly the same as in the underlying JS SDK (see also some of the exotic names of the WebGL API in package:web).

If we prefer camelCase in the Dart side of things, it can definitely be done:

@JS('login_hint')
String? loginHint,

And it wouldn't be a hard migration, after all I suspect it's only us using this package directly.

Let me know if you want this camelCase'd, I can create a task and go for it later :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that it's worth doing a breaking change for, it just struck me as odd so I was curious.

@ditman ditman requested a review from stuartmorgan-g October 13, 2023 02:51
@ditman
Copy link
Member Author

ditman commented Oct 13, 2023

Please PTAL @stuartmorgan when you find it convenient. Thanks!

stuartmorgan-g
stuartmorgan-g approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the bots are happy). Thanks for the new tests!

@ditman
Copy link
Member Author

ditman commented Oct 13, 2023

warning - example/integration_test/js_interop_id_test.dart:11:63 - The name allowInterop is shown, but isn't used. Try removing the name from the list of shown members. - unused_shown_name

woopsie!

@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 14, 2023

auto label is removed for flutter/packages/5123, due to - The status or check suite Linux_android android_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 14, 2023
@ditman ditman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2023
@auto-submit auto-submit bot merged commit d439062 into flutter:main Oct 17, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 17, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
d439062 [gis_web] Adds FedCM toggle. (flutter/packages#5123)
c568a93
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 17, 2023
@engine-flutter-autoroll
Roll Packages from 872d6d2 to d439062 (4 revisions) (#136724)
5739397 
flutter/packages@872d6d2...d439062

2023-10-17 [email protected] [gis_web] Adds FedCM toggle. (flutter/packages#5123)
2023-10-17 [email protected] [quick_actions] Convert android to pigeon (flutter/packages#5099)
2023-10-16 [email protected] [flutter_image] added example app (flutter/packages#4353)
2023-10-16 [email protected] Roll Flutter from b00216b to afc3916 (12 revisions) (flutter/packages#5156)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@ditman ditman deleted the add-fedcm-toggle branch October 18, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

@ditman ditman

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ditman @stuartmorgan-g