-
Couldn't load subscription status.
- Fork 3.5k
[quick_actions] Convert android to pigeon #5099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62579ff to
b294b3c
Compare
tarrinneal
commented
Oct 13, 2023
...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java
Outdated
Show resolved
Hide resolved
tarrinneal
commented
Oct 13, 2023
...ons_android/android/src/main/java/io/flutter/plugins/quickactions/MethodCallHandlerImpl.java
Outdated
Show resolved
Hide resolved
stuartmorgan-g
requested changes
Oct 13, 2023
...ctions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActionsPlugin.java
Outdated
Show resolved
Hide resolved
...ctions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActionsPlugin.java
Outdated
Show resolved
Hide resolved
...ctions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActionsPlugin.java
Outdated
Show resolved
Hide resolved
...ctions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActionsPlugin.java
Outdated
Show resolved
Hide resolved
..._actions_android/android/src/test/java/io/flutter/plugins/quickactions/QuickActionsTest.java
Outdated
Show resolved
Hide resolved
...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java
Outdated
Show resolved
Hide resolved
...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java
Outdated
Show resolved
Hide resolved
...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java
Outdated
Show resolved
Hide resolved
...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java
Outdated
Show resolved
Hide resolved
...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java
Outdated
Show resolved
Hide resolved
stuartmorgan-g
requested changes
Oct 16, 2023
...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java
Outdated
Show resolved
Hide resolved
...uick_actions_android/android/src/main/java/io/flutter/plugins/quickactions/QuickActions.java
Outdated
Show resolved
Hide resolved
packages/quick_actions/quick_actions_android/lib/quick_actions_android.dart
Outdated
Show resolved
Hide resolved
packages/quick_actions/quick_actions_android/lib/quick_actions_android.dart
Outdated
Show resolved
Hide resolved
packages/quick_actions/quick_actions_android/test/quick_actions_android_test.dart
Outdated
Show resolved
Hide resolved
stuartmorgan-g
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 17, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 17, 2023
flutter/packages@872d6d2...d439062 2023-10-17 [email protected] [gis_web] Adds FedCM toggle. (flutter/packages#5123) 2023-10-17 [email protected] [quick_actions] Convert android to pigeon (flutter/packages#5099) 2023-10-16 [email protected] [flutter_image] added example app (flutter/packages#4353) 2023-10-16 [email protected] Roll Flutter from b00216b to afc3916 (12 revisions) (flutter/packages#5156) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts from direct use of method channels to using Pigeon.
Part of flutter/flutter#117844
part of flutter/flutter#117913
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.