[pigeon] Add macOS Obj-C support #4267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
commented
Jun 21, 2023
There was a problem hiding this comment.
This is the actual fix; everything else is for testing :)
stuartmorgan-g
commented
Jun 21, 2023
There was a problem hiding this comment.
This and the .m file are direct copies of the iOS version, with just the import changed.
tarrinneal
approved these changes
Jun 21, 2023
...on/platform_tests/alternate_language_test_plugin/example/macos/RunnerTests/RunnerTests.swift
Show resolved
Hide resolved
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 22, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 22, 2023
flutter/packages@9af50d4...95bc1c6 2023-06-22 [email protected] [ci] Switch analyze tests to LUCI (flutter/packages#4264) 2023-06-22 [email protected] Roll Flutter from fc8856e to c40baf4 (57 revisions) (flutter/packages#4270) 2023-06-22 [email protected] [ci] Add LUCI version of build-all for Android (flutter/packages#4236) 2023-06-21 [email protected] [go_router] Adds parent navigator key to ShellRoute and StatefulShell� (flutter/packages#4201) 2023-06-21 [email protected] [pigeon] Add macOS Obj-C support (flutter/packages#4267) 2023-06-21 [email protected] [tools] Fix format instructions (flutter/packages#4259) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Objective-C a supported language for macOS in Pigeon, and adds integration tests for it.
Also adjusts CI to only run the macOS version of the integration tests, as is already the case for Swift, since there's less complexity in running macOS integration tests than Obj-C integration tests, and the tests are identical. (As with Swift, we can easily revisit that if we ever find that we miss a bug due to this.)
Fixes flutter/flutter#124724
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).