[ci] Add LUCI version of build-all for Android #4236
Conversation
Adds a new Linux_android configuration, and an initial test (build-all-packages) using it. This is the simplest Android test since it doesn't actually run anything, so starting with this one as a foundation to test future web-based tests. Part of flutter/flutter#114373
| dependencies: >- | ||
| [ | ||
| {"dependency": "android_sdk", "version": "version:33v6"}, | ||
| {"dependency": "open_jdk", "version": "version:11"}, |
There was a problem hiding this comment.
These were taken from flutter/flutter's configs. I believe it's similar to what we are currently using in Cirrus, so hopefully it'll transition smoothly.
There was a problem hiding this comment.
Can we use a different platform name to avoid confusion from framework ones, which needs a tethered android phone? Alternatively, I am wondering if we can consolidate the to-be-added (linux) platforms, and leave the dependencies difference on target level.
There was a problem hiding this comment.
Can we use a different platform name to avoid confusion from framework ones, which needs a tethered android phone?
IMO the flutter/flutter naming is confusing, because linux_android has one specific device, then there are a bunch of linux_android_somedevice variants with different devices. Why does linux_android not match the naming scheme there?
Also, I don't expect to need device-specific configs in this repo since we use FTL for device tests, so the naming should be much simpler here.
Alternatively, I am wondering if we can consolidate the to-be-added (linux) platforms, and leave the dependencies difference on target level.
Do you mean _desktop, _web, and _android? That would mean duplicating all of the generic platform-targeting configuration (These two lines for Android, cmake/clang/etc for desktop, etc.) for every single test, which makes things very redundant and harder to update. I would really like to avoid that.
Unless you mean putting all the things needed for all three into a single Linux configuration. I'm fine with that in terms of file structure, but I assume that slows things down unnecessarily in CI.
There was a problem hiding this comment.
Alternatively, I am wondering if we can consolidate the to-be-added (linux) platforms
(And FWIW, I believe this is the last one I will need to add. My plan was one generic one for things like Dart analyze and unit tests that have no target, and one for each of the three targets that Linux hosts are used for.)
There was a problem hiding this comment.
Different platforms handling different set of tasks are expected, and sound good to me.
We have some metrics data depending on the platform assuming Linux_android targets are tied to a phone. Do you mind holding a bit on this PR before I find a good way to handle the metrics?
#4229 LGTM to merge.
There was a problem hiding this comment.
Created flutter/flutter#129039, I expect to fix it in the coming fixit week with a higher priority.
There was a problem hiding this comment.
flutter/flutter#129039 is fixed. This should be unblocked.
stuartmorgan-g
added
the
autosubmit
flutter/packages@9af50d4...95bc1c6 2023-06-22 [email protected] [ci] Switch analyze tests to LUCI (flutter/packages#4264) 2023-06-22 [email protected] Roll Flutter from fc8856e to c40baf4 (57 revisions) (flutter/packages#4270) 2023-06-22 [email protected] [ci] Add LUCI version of build-all for Android (flutter/packages#4236) 2023-06-21 [email protected] [go_router] Adds parent navigator key to ShellRoute and StatefulShell� (flutter/packages#4201) 2023-06-21 [email protected] [pigeon] Add macOS Obj-C support (flutter/packages#4267) 2023-06-21 [email protected] [tools] Fix format instructions (flutter/packages#4259) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Adds a new Linux_android configuration, and an initial test (build-all-packages) using it.
This is the simplest Android test since it doesn't actually run anything, so starting with this one as a foundation to test future web-based tests.
Part of flutter/flutter#114373