[RenderListWheelViewport] Update content dimensions to prevent scroll offset changes #96102
Conversation
flutter-dashboard
bot
added
f: scrolling
|
Calling performLayout from within performLayout is really dubious... are we sure about this? |
|
(cc @Piinks who may have opinions on this code) |
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Hey @xu-baolin, happy new year! 🎉
I wonder how we handle this in other viewports, isn't there a correction we apply if !offset.applyContentDimensions?
There was a problem hiding this comment.
Adjust the content dimensions for there is a special test case which allows the delegate to provide a null widget child.
There was a problem hiding this comment.
The logic here is difficult to understand, so I linked this test case in the comments.
Yes, it seemed weird to do so, I changed a solution. |
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
This looks a lot better, thanks for updating!
There was a problem hiding this comment.
Can you put this comment in the test itself? If a future change breaks the test, it will be helpful to have that context there as well.
There was a problem hiding this comment.
Why move this? It does not seem to change later in the course of laying out.
There was a problem hiding this comment.
Just move to where first use it.
Piinks
changed the title
Piinks
changed the title
…t scroll offset changes (flutter/flutter#96102)
…t scroll offset changes (flutter/flutter#96102)
…t scroll offset changes (flutter/flutter#96102)
…t scroll offset changes (flutter/flutter#96102)
4 participants
Fixes #90953
Update content dimensions first when layout to prevent scroll offset changes.