fix a CupertinoDatePicker bug #112697
Merged
fix a CupertinoDatePicker bug #112697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: scrolling
xu-baolin
force-pushed
the
xbl000930
branch
from
c2c2907 to
c41d8fa
Compare
Piinks
reviewed
Oct 3, 2022
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
it will apply unboundary dimensions which may break the BouncingScrollPhysics boundary.
🤯
Piinks
reviewed
Oct 3, 2022
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
This looks good, thank you! Can you check out the failing tests?
This was referenced Oct 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112526
This bug was introduced by #96102, which wants to update the pixels before determining what should be shown when the children's count changes.
The root cause of this issue,
If the children's count is indeterminate, it will apply unboundary dimensions which may break the BouncingScrollPhysics boundary.