Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Call drawPaint instead of drawPath if there's clip #5937

Merged
merged 1 commit into from
Aug 4, 2018
Merged

Call drawPaint instead of drawPath if there's clip #5937

merged 1 commit into from
Aug 4, 2018

Conversation

liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Aug 3, 2018

If we want to avoid the bleeding edge artifact (flutter/flutter#18057 (comment)) using saveLayer, we have to call drawPaint instead of drawPath as anti-aliased drawPath will always have such artifacts.

This is discovered when I try to add golden tests for such bleeding artifacts using our new Clip enum.

@gspencergoog
Copy link
Contributor

gspencergoog commented Aug 3, 2018 •
edited
Loading

Is there any test we can do to make sure that we don't regress in this regard? Like adding a golden file test for the case that Ian highlights in the bug?

Edit: Oh, I see above that you're working on those. Are you planning to add some to this PR, or is that separate?

@liyuqian
Copy link
Contributor Author

liyuqian commented Aug 3, 2018

@gspencergoog it's a separate PR because it's on flutter/flutter: flutter/flutter#20205

@gspencergoog
Copy link
Contributor

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@liyuqian
Copy link
Contributor Author

liyuqian commented Aug 3, 2018

BTW, here's the updated golden files: flutter/goldens@cb1fa8a?short_path=57b30ce#diff-57b30cea9b10b7ca689009854e12d70e

@liyuqian liyuqian merged commit ecbb2b2 into flutter:master Aug 4, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2018
@engine-flutter-autoroll
Roll engine 4893b07..ecbb2b2 (9 commits)
d800d07 
flutter/engine@4893b07...ecbb2b2

git log 4893b07..ecbb2b2 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2018
@engine-flutter-autoroll
Roll engine 4893b07..aaf4a9a (10 commits)
13d7749 
flutter/engine@4893b07...aaf4a9a

git log 4893b07..aaf4a9a --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2018
@engine-flutter-autoroll
Roll engine 4893b07..97aea09 (11 commits)
ef26398 
flutter/engine@4893b07...97aea09

git log 4893b07..97aea09 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+[email protected] Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2018
Closed
liyuqian added a commit to flutter/goldens that referenced this pull request Aug 4, 2018
@liyuqian
Add updated golden files
64b7a3a 
To unblock engine roll after flutter/engine#5937
@liyuqian liyuqian mentioned this pull request Aug 4, 2018
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2018
@engine-flutter-autoroll
Roll engine 4893b07..63ede2e (12 commits)
5369889 
flutter/engine@4893b07...63ede2e

git log 4893b07..63ede2e --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-05 37626415+[email protected] Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2018
@engine-flutter-autoroll
Roll engine 4893b07..c6baaaf (13 commits)
03e0111 
flutter/engine@4893b07...c6baaaf

git log 4893b07..c6baaaf --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-05 [email protected] Replace acquire+release thread annotation with excludes (flutter/engine#5944)
2018-08-05 37626415+[email protected] Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2018
@engine-flutter-autoroll
Roll engine 4893b07..f4464a8 (14 commits)
caf79e8 
flutter/engine@4893b07...f4464a8

git log 4893b07..f4464a8 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-06 37626415+[email protected] Roll src/third_party/skia 2e77f54f46e8..12fb9cfeee07 (1 commits) (flutter/engine#5945)
2018-08-05 [email protected] Replace acquire+release thread annotation with excludes (flutter/engine#5944)
2018-08-05 37626415+[email protected] Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
liyuqian added a commit to liyuqian/flutter that referenced this pull request Aug 6, 2018
@liyuqian
Roll engine to ecbb2b2
f01f69c 
ecbb2b2 Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
597a508 Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
715b64e Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
ffbafc8 Flush all embedded Android views on hot restart. (flutter/engine#5929)
9fe6a57 Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
3b66f20 Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
391ac2f Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)

Goldens:
64b7a3a Add updated golden files
cb1fa8a Update golden files of PhysicalModel and PhysicalShape
3baed8d Add a goldens package for the embedded Android views integration test.
liyuqian added a commit to flutter/flutter that referenced this pull request Aug 6, 2018
@liyuqian
Roll engine to ecbb2b2 (#20230)
8b0a3be 
ecbb2b2 Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
597a508 Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
715b64e Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
ffbafc8 Flush all embedded Android views on hot restart. (flutter/engine#5929)
9fe6a57 Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
3b66f20 Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
391ac2f Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)

Goldens:
64b7a3a Add updated golden files
cb1fa8a Update golden files of PhysicalModel and PhysicalShape
3baed8d Add a goldens package for the embedded Android views integration test.
@liyuqian liyuqian deleted the physical branch September 12, 2018 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@Hixie Hixie Awaiting requested review from Hixie

1 more reviewer

@gspencergoog gspencergoog gspencergoog approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liyuqian @gspencergoog @googlebot