Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add an explicit -[FlutterViewController init] implementation #5924

Merged
merged 3 commits into from
Aug 2, 2018
Merged

Add an explicit -[FlutterViewController init] implementation #5924

merged 3 commits into from
Aug 2, 2018

Conversation

jamesderlin
Copy link
Contributor

-[FlutterViewController init] currently works because it inherits
the -[UIViewController init] convenience initializer that invokes
the -[UIViewController initWithNibName:bundle:] designated
initializer that FlutterViewController overrides.

However, this doesn't seem to be explicitly documented, so it's a bit
confusing (or at least non-obvious), and it seems potentially
brittle. Add an explicit implementation of -[FlutterViewController init] instead.

@jamesderlin
Add an explicit -[FlutterViewController init] implementation
00a6b48 
`-[FlutterViewController init]` currently works because it inherits
the `-[UIViewController init]` convenience initializer that invokes
the `-[UIViewController initWithNibName:bundle:]` designated
initializer that `FlutterViewController` overrides.

However, this doesn't seem to be explicitly documented, so it's a bit
confusing (or at least non-obvious), and it seems potentially
brittle.  Add an explicit implementation of `-[FlutterViewController
init]` instead.
@jamesderlin jamesderlin merged commit 76ec93d into flutter:master Aug 2, 2018
@jamesderlin jamesderlin deleted the jamesderlin/master branch August 2, 2018 21:03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2018
@engine-flutter-autoroll
Roll engine 4893b07..9fe6a57 (5 commits)
aa63d5f 
flutter/engine@4893b07...9fe6a57

git log 4893b07..9fe6a57 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2018
@engine-flutter-autoroll
Roll engine 4893b07..ffbafc8 (6 commits)
1ab5a7a 
flutter/engine@4893b07...ffbafc8

git log 4893b07..ffbafc8 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
This was referenced Aug 3, 2018
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2018
@engine-flutter-autoroll
Roll engine 4893b07..715b64e (7 commits)
3964864 
flutter/engine@4893b07...715b64e

git log 4893b07..715b64e --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 3, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2018
@engine-flutter-autoroll
Roll engine 4893b07..597a508 (8 commits)
3ad7686 
flutter/engine@4893b07...597a508

git log 4893b07..597a508 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2018
@engine-flutter-autoroll
Roll engine 4893b07..ecbb2b2 (9 commits)
d800d07 
flutter/engine@4893b07...ecbb2b2

git log 4893b07..ecbb2b2 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2018
@engine-flutter-autoroll
Roll engine 4893b07..aaf4a9a (10 commits)
13d7749 
flutter/engine@4893b07...aaf4a9a

git log 4893b07..aaf4a9a --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 4, 2018
@engine-flutter-autoroll
Roll engine 4893b07..97aea09 (11 commits)
ef26398 
flutter/engine@4893b07...97aea09

git log 4893b07..97aea09 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-03 37626415+[email protected] Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2018
Closed
@liyuqian liyuqian mentioned this pull request Aug 4, 2018
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 5, 2018
@engine-flutter-autoroll
Roll engine 4893b07..63ede2e (12 commits)
5369889 
flutter/engine@4893b07...63ede2e

git log 4893b07..63ede2e --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-05 37626415+[email protected] Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2018
@engine-flutter-autoroll
Roll engine 4893b07..c6baaaf (13 commits)
03e0111 
flutter/engine@4893b07...c6baaaf

git log 4893b07..c6baaaf --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-05 [email protected] Replace acquire+release thread annotation with excludes (flutter/engine#5944)
2018-08-05 37626415+[email protected] Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 6, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2018
@engine-flutter-autoroll
Roll engine 4893b07..f4464a8 (14 commits)
caf79e8 
flutter/engine@4893b07...f4464a8

git log 4893b07..f4464a8 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-06 37626415+[email protected] Roll src/third_party/skia 2e77f54f46e8..12fb9cfeee07 (1 commits) (flutter/engine#5945)
2018-08-05 [email protected] Replace acquire+release thread annotation with excludes (flutter/engine#5944)
2018-08-05 37626415+[email protected] Roll src/third_party/skia 59aabbcf3b0d..2e77f54f46e8 (1 commits) (flutter/engine#5943)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 71fe8baccc01..59aabbcf3b0d (1 commits) (flutter/engine#5942)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 4c3b63e289c5..71fe8baccc01 (3 commits) (flutter/engine#5940)
2018-08-03 [email protected] Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
2018-08-03 37626415+[email protected] Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
2018-08-03 [email protected] Flush all embedded Android views on hot restart. (flutter/engine#5929)
2018-08-03 37626415+[email protected] Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
2018-08-02 [email protected] Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
2018-08-02 37626415+[email protected] Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
2018-08-02 [email protected] Roll Dart to b04def964c428ada007cca7ef6b4936001db965d (flutter/engine#5928)
2018-08-02 [email protected] Add an explicit `-[FlutterViewController init]` implementation (flutter/engine#5924)

The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesderlin @chinmaygarde @googlebot