This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[ios]limit web view not tappable workaround to a limited depth #57193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
commented
Dec 13, 2024
| // Passing a limit of 0 means only searching for platform view itself; Pass 1 to include its | ||
| // children as well, and so on. We should be conservative and start with a small number. The | ||
| // AdMob banner has a WKWebView at depth 7. | ||
| if ([self containsWebView:self.embeddedView remainingSubviewDepth:1]) { |
Contributor
Author
There was a problem hiding this comment.
Passing 1 means searching for itself and its immediate children. AdMob is at depth 7. I think we should start small here to be conservative, and increase only when necessary.
hellohuanlin
added
the
autosubmit
This was referenced Dec 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
… subviews recursively #57168 (#57172) CP for #57168 and #57193 *List which issues are fixed by this PR. You must list at least one issue.* flutter/flutter#158961 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 14, 2024
…160290) flutter/engine@f0ff4f2...c4e3cc2 2024-12-13 [email protected] [skwasm] Fix implementation of SkwasmPath.relativeLineTo (flutter/engine#57201) 2024-12-13 [email protected] Made compilation error colors come through et. (flutter/engine#57174) 2024-12-13 [email protected] Roll Fuchsia Linux SDK from iWMEbVYaNdH8RJmXZ... to iYz_WkWk1uPr8BLSZ... (flutter/engine#57198) 2024-12-13 [email protected] [web] allow imports to line-break (flutter/engine#57170) 2024-12-13 [email protected] [ios]limit web view not tappable workaround to a limited depth (flutter/engine#57193) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from iWMEbVYaNdH8 to iYz_WkWk1uPr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
… AND "enable the webview non tappable workaround by checking subviews recursively #57168" (#57176) CP for 3 PRs: #56804 and #57168 and #57193 This is for 3.28. Since the previous PR was not merged, so I combined the 2 PRs to make it easier to merge. *List which issues are fixed by this PR. You must list at least one issue.* pichillilorenzo/flutter_inappwebview#2415 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…er/engine#57193) This PR limits the search depth, because we don't want to enable this workaround for AdMob banner, which has a WKWebView in the depth of 7. See the previous PR for more context: flutter/engine#57168 I was able to confirm that this returns YES for the 3P plugin, and NO for AdMob. *List which issues are fixed by this PR. You must list at least one issue.* flutter#158961 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
phamnhuvu-dev
pushed a commit
to phamnhuvu-dev/engine
that referenced
this pull request
Jan 7, 2025
… subviews recursively flutter#57168 (flutter#57172) CP for flutter#57168 and flutter#57193 *List which issues are fixed by this PR. You must list at least one issue.* flutter/flutter#158961 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].* [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR limits the search depth, because we don't want to enable this workaround for AdMob banner, which has a WKWebView in the depth of 7. See the previous PR for more context: #57168
I was able to confirm that this returns YES for the 3P plugin, and NO for AdMob.
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#158961
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.