This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] allow imports to line-break #57170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Dec 12, 2024
yjbanov
changed the title
yjbanov
force-pushed
the
allow-imports-to-line-break
branch
from
045cd24 to
81816cc
Compare
Member
|
Looks like something is still failing with the line breaks… |
mdebbar
approved these changes
Dec 13, 2024
Contributor
|
@yjbanov I think we need to remove this restriction now: engine/web_sdk/test/js_access_test.dart Lines 184 to 187 in f0ff4f2 (this is what's causing the CI failure) |
Contributor
Author
|
Yep, fixed. |
yjbanov
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/57170, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
goderbauer
added
the
autosubmit
ditman
reviewed
Dec 13, 2024
| // Remove library directives. | ||
| AllReplacer(RegExp(r'\nlibrary .+;'), ''), | ||
| // Remove imports/exports from all part files. | ||
| AllReplacer(RegExp(r"\nimport '.+'\n\s*if \(dart\.library\..*\) '.*';"), ''), |
Member
There was a problem hiding this comment.
Not that it matters too much, but I'd do a simpler regex to handle both import cases?
?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 14, 2024
…160290) flutter/engine@f0ff4f2...c4e3cc2 2024-12-13 [email protected] [skwasm] Fix implementation of SkwasmPath.relativeLineTo (flutter/engine#57201) 2024-12-13 [email protected] Made compilation error colors come through et. (flutter/engine#57174) 2024-12-13 [email protected] Roll Fuchsia Linux SDK from iWMEbVYaNdH8RJmXZ... to iYz_WkWk1uPr8BLSZ... (flutter/engine#57198) 2024-12-13 [email protected] [web] allow imports to line-break (flutter/engine#57170) 2024-12-13 [email protected] [ios]limit web view not tappable workaround to a limited depth (flutter/engine#57193) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from iWMEbVYaNdH8 to iYz_WkWk1uPr If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
We are about to `dart format` all the Dart code in the repo, which line-breaks some of our imports. This PR updates `sdk_rewriter.dart` to support line-broken imports.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are about to
dart formatall the Dart code in the repo, which line-breaks some of our imports.This PR updates
sdk_rewriter.dartto support line-broken imports.