Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@robert-ancell
Copy link
Contributor

Use FlMockBinaryMessenger instead of mocking the whole engine.

@robert-ancell robert-ancell force-pushed the linux-basic-message-channel-test-mock-messenger branch from ef26fea to f74dc4b Compare December 11, 2024 21:02
Copy link

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@robert-ancell robert-ancell merged commit c5962d1 into flutter:main Dec 12, 2024
28 checks passed
@robert-ancell robert-ancell deleted the linux-basic-message-channel-test-mock-messenger branch December 12, 2024 19:38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 12, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 13, 2024
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 13, 2024
…160220)

flutter/engine@9b51e30...5eedfef

2024-12-13 [email protected] Normalize round rect bounds when coming from
Flutter (flutter/engine#57171)
2024-12-13 [email protected] [ios]enable
the webview non tappable workaround by checking subviews recursively
(flutter/engine#57168)
2024-12-12 [email protected] removed c style
casts and enabled the lint (flutter/engine#57162)
2024-12-12 [email protected] [Impeller] exploit perfect hash for
SamplerDescriptor. (flutter/engine#57036)
2024-12-12 [email protected] Reenabled
labelling test with a capabilities check. (flutter/engine#57160)
2024-12-12 [email protected] [Impeller] dont print format strings
for blend filter and snapshots. (flutter/engine#57105)
2024-12-12 [email protected] Make fl_engine_send_key_event
into a standard async function. (flutter/engine#57112)
2024-12-12 [email protected] Roll Fuchsia Linux SDK from
HJ57Y3zxqDamI8qkY... to iWMEbVYaNdH8RJmXZ... (flutter/engine#57163)
2024-12-12 [email protected] Migrate FlPlatformChannel tests
to FlMockBinaryMessenger (flutter/engine#57140)
2024-12-12 [email protected] Migrate FlBasicMessageChannel
tests to FlMockBinaryMessenger (flutter/engine#57115)
2024-12-12 [email protected] Migrate layers and layer_tree to
DisplayList/Impeller geometry classes (flutter/engine#57153)
2024-12-12 [email protected] [web] Use CanvasKit to run tests under
engine/ (flutter/engine#54786)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from HJ57Y3zxqDam to iWMEbVYaNdH8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
…/engine#57115)

Use FlMockBinaryMessenger instead of mocking the whole engine.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants