This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Use CanvasKit to run tests under engine/ #54786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
A firefox upgrade is long overdue. This upgrade fixes some failing tests in #54786
yjbanov
approved these changes
Dec 12, 2024
mdebbar
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 13, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 13, 2024
…160220) flutter/engine@9b51e30...5eedfef 2024-12-13 [email protected] Normalize round rect bounds when coming from Flutter (flutter/engine#57171) 2024-12-13 [email protected] [ios]enable the webview non tappable workaround by checking subviews recursively (flutter/engine#57168) 2024-12-12 [email protected] removed c style casts and enabled the lint (flutter/engine#57162) 2024-12-12 [email protected] [Impeller] exploit perfect hash for SamplerDescriptor. (flutter/engine#57036) 2024-12-12 [email protected] Reenabled labelling test with a capabilities check. (flutter/engine#57160) 2024-12-12 [email protected] [Impeller] dont print format strings for blend filter and snapshots. (flutter/engine#57105) 2024-12-12 [email protected] Make fl_engine_send_key_event into a standard async function. (flutter/engine#57112) 2024-12-12 [email protected] Roll Fuchsia Linux SDK from HJ57Y3zxqDamI8qkY... to iWMEbVYaNdH8RJmXZ... (flutter/engine#57163) 2024-12-12 [email protected] Migrate FlPlatformChannel tests to FlMockBinaryMessenger (flutter/engine#57140) 2024-12-12 [email protected] Migrate FlBasicMessageChannel tests to FlMockBinaryMessenger (flutter/engine#57115) 2024-12-12 [email protected] Migrate layers and layer_tree to DisplayList/Impeller geometry classes (flutter/engine#57153) 2024-12-12 [email protected] [web] Use CanvasKit to run tests under engine/ (flutter/engine#54786) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from HJ57Y3zxqDam to iWMEbVYaNdH8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
A firefox upgrade is long overdue. This upgrade fixes some failing tests in flutter/engine#54786
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Let's start running the tests under `engine/` using the CanvasKit renderer instead of HTML. This PR also: - Moves several tests from `engine/` to `html/` since they were testing html-specific stuff. - Deletes `test/canvaskit/semantics_test.dart` since it's just an "alias" for `test/engine/semantics/semantics_test.dart`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's start running the tests under
engine/using the CanvasKit renderer instead of HTML.This PR also:
engine/tohtml/since they were testing html-specific stuff.test/canvaskit/semantics_test.dartsince it's just an "alias" fortest/engine/semantics/semantics_test.dart.