This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux] Configure depth and stencil framebuffer attachments needed for Impeller #56516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @jonahwilliams - this is the source of the clipping issue with Impeller on Linux/OpenGL that I mentioned today |
jonahwilliams
approved these changes
Nov 12, 2024
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
Change LGTM
Though this is making me realize that we're probably also missing a multisampling configuration for linux too.
Contributor
|
We should also get an LGTM from @robert-ancell |
jason-simmons
force-pushed
the
linux_framebuffer_depth_stencil
branch
from
b8a66c0 to
3c5a209
Compare
jason-simmons
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2024
… needed for Impeller (flutter/engine#56516)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 13, 2024
…158541) flutter/engine@877abb9...08348c9 2024-11-12 [email protected] [Linux] Configure depth and stencil framebuffer attachments needed for Impeller (flutter/engine#56516) 2024-11-12 [email protected] macOS: ARC bridge casts for FlutterMetalTexture.user_data (flutter/engine#56518) 2024-11-12 [email protected] [Impeller] prevent no-op backend from throwing exceptions during image decoding (flutter/engine#56522) 2024-11-12 [email protected] Roll Dart SDK from 69170fac244c to 5f42ef8f15d5 (4 revisions) (flutter/engine#56539) 2024-11-12 [email protected] Roll Fuchsia Linux SDK from BajfrJuYeyWvnBhuM... to z-cm2nR0aJ4lXfwZ0... (flutter/engine#56538) 2024-11-12 [email protected] Roll Skia from aa099ff91e2f to 7d5c206fc873 (6 revisions) (flutter/engine#56541) 2024-11-12 [email protected] [Impeller] In canvas_unittests, only create an MSAA offscreen texture if the platform supports MSAA (flutter/engine#56542) 2024-11-12 [email protected] [iOS] Fix slider semantics node answer to accessibility activate (flutter/engine#56427) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from BajfrJuYeyWv to z-cm2nR0aJ4l If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.