[Linux] Configure depth and stencil framebuffer attachments needed for Impeller (#56516)

Author: jason-simmons

ci/licenses_golden/licenses_flutter

@@ -44969,6 +44969,7 @@ ORIGIN: ../../../flutter/shell/platform/linux/fl_event_channel.cc + ../../../flu
 ORIGIN: ../../../flutter/shell/platform/linux/fl_event_channel_test.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/platform/linux/fl_framebuffer.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/platform/linux/fl_framebuffer.h + ../../../flutter/LICENSE
+ORIGIN: ../../../flutter/shell/platform/linux/fl_framebuffer_test.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/platform/linux/fl_gnome_settings.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/platform/linux/fl_gnome_settings.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/shell/platform/linux/fl_gnome_settings_test.cc + ../../../flutter/LICENSE
@@ -47868,6 +47869,7 @@ FILE: ../../../flutter/shell/platform/linux/fl_event_channel.cc
 FILE: ../../../flutter/shell/platform/linux/fl_event_channel_test.cc
 FILE: ../../../flutter/shell/platform/linux/fl_framebuffer.cc
 FILE: ../../../flutter/shell/platform/linux/fl_framebuffer.h
+FILE: ../../../flutter/shell/platform/linux/fl_framebuffer_test.cc
 FILE: ../../../flutter/shell/platform/linux/fl_gnome_settings.cc
 FILE: ../../../flutter/shell/platform/linux/fl_gnome_settings.h
 FILE: ../../../flutter/shell/platform/linux/fl_gnome_settings_test.cc

shell/platform/linux/BUILD.gn

@@ -211,6 +211,7 @@ executable("flutter_linux_unittests") {
     "fl_dart_project_test.cc",
     "fl_engine_test.cc",
     "fl_event_channel_test.cc",
+    "fl_framebuffer_test.cc",
     "fl_gnome_settings_test.cc",
     "fl_json_message_codec_test.cc",
     "fl_json_method_codec_test.cc",

shell/platform/linux/fl_framebuffer.cc

@@ -63,6 +63,19 @@ FlFramebuffer* fl_framebuffer_new(GLint format, size_t width, size_t height) {
   glFramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0, GL_TEXTURE_2D,
                          provider->texture_id, 0);
 
+  GLuint depth_stencil;
+  glGenRenderbuffers(1, &depth_stencil);
+  glBindRenderbuffer(GL_RENDERBUFFER, depth_stencil);
+  glRenderbufferStorage(GL_RENDERBUFFER,      // target
+                        GL_DEPTH24_STENCIL8,  // internal format
+                        width,                // width
+                        height                // height
+  );
+  glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT,
+                            GL_RENDERBUFFER, depth_stencil);
+  glFramebufferRenderbuffer(GL_FRAMEBUFFER, GL_STENCIL_ATTACHMENT,
+                            GL_RENDERBUFFER, depth_stencil);
+
   return provider;
 }
 

shell/platform/linux/fl_framebuffer_test.cc

@@ -0,0 +1,28 @@
+// Copyright 2013 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "gtest/gtest.h"
+
+#include "flutter/common/constants.h"
+#include "flutter/fml/logging.h"
+#include "flutter/shell/platform/linux/fl_framebuffer.h"
+#include "flutter/shell/platform/linux/testing/mock_epoxy.h"
+
+TEST(FlFramebufferTest, HasDepthStencil) {
+  ::testing::NiceMock<flutter::testing::MockEpoxy> epoxy;
+
+  g_autoptr(FlFramebuffer) framebuffer = fl_framebuffer_new(GL_RGB, 100, 100);
+
+  GLint depth_type = GL_NONE;
+  glGetFramebufferAttachmentParameteriv(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT,
+                                        GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE,
+                                        &depth_type);
+  EXPECT_NE(depth_type, GL_NONE);
+
+  GLint stencil_type = GL_NONE;
+  glGetFramebufferAttachmentParameteriv(GL_FRAMEBUFFER, GL_STENCIL_ATTACHMENT,
+                                        GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE,
+                                        &stencil_type);
+  EXPECT_NE(stencil_type, GL_NONE);
+}

shell/platform/linux/testing/mock_epoxy.cc

@@ -4,6 +4,7 @@
 // found in the LICENSE file.
 
 #include "flutter/shell/platform/linux/testing/mock_epoxy.h"
+#include "flutter/fml/logging.h"
 
 using namespace flutter::testing;
 
@@ -352,10 +353,14 @@ EGLBoolean _eglSwapBuffers(EGLDisplay dpy, EGLSurface surface) {
 
 static GLuint bound_texture_2d;
 
+static std::map<GLenum, GLuint> framebuffer_renderbuffers;
+
 void _glAttachShader(GLuint program, GLuint shader) {}
 
 static void _glBindFramebuffer(GLenum target, GLuint framebuffer) {}
 
+static void _glBindRenderbuffer(GLenum target, GLuint framebuffer) {}
+
 static void _glBindTexture(GLenum target, GLuint texture) {
   if (target == GL_TEXTURE_2D) {
     bound_texture_2d = texture;
@@ -396,6 +401,13 @@ void _glDeleteShader(GLuint shader) {}
 
 void _glDeleteTextures(GLsizei n, const GLuint* textures) {}
 
+static void _glFramebufferRenderbuffer(GLenum target,
+                                       GLenum attachment,
+                                       GLenum renderbuffertarget,
+                                       GLuint renderbuffer) {
+  framebuffer_renderbuffers[attachment] = renderbuffer;
+}
+
 static void _glFramebufferTexture2D(GLenum target,
                                     GLenum attachment,
                                     GLenum textarget,
@@ -414,6 +426,26 @@ static void _glGenFramebuffers(GLsizei n, GLuint* framebuffers) {
   }
 }
 
+static void _glGenRenderbuffers(GLsizei n, GLuint* renderbuffers) {
+  for (GLsizei i = 0; i < n; i++) {
+    renderbuffers[i] = 0;
+  }
+}
+
+static void _glGetFramebufferAttachmentParameteriv(GLenum target,
+                                                   GLenum attachment,
+                                                   GLenum pname,
+                                                   GLint* params) {
+  if (pname == GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE) {
+    auto it = framebuffer_renderbuffers.find(attachment);
+    *params =
+        (it != framebuffer_renderbuffers.end()) ? GL_RENDERBUFFER : GL_NONE;
+  } else if (pname == GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME) {
+    auto it = framebuffer_renderbuffers.find(attachment);
+    *params = (it != framebuffer_renderbuffers.end()) ? it->second : 0;
+  }
+}
+
 static void _glGetIntegerv(GLenum pname, GLint* data) {
   if (pname == GL_TEXTURE_BINDING_2D) {
     *data = bound_texture_2d;
@@ -466,6 +498,11 @@ static GLenum _glGetError() {
 
 void _glLinkProgram(GLuint program) {}
 
+void _glRenderbufferStorage(GLenum target,
+                            GLenum internalformat,
+                            GLsizei width,
+                            GLsizei height) {}
+
 void _glShaderSource(GLuint shader,
                      GLsizei count,
                      const GLchar* const* string,
@@ -536,6 +573,7 @@ EGLBoolean (*epoxy_eglSwapBuffers)(EGLDisplay dpy, EGLSurface surface);
 
 void (*epoxy_glAttachShader)(GLuint program, GLuint shader);
 void (*epoxy_glBindFramebuffer)(GLenum target, GLuint framebuffer);
+void (*epoxy_glBindRenderbuffer)(GLenum target, GLuint renderbuffer);
 void (*epoxy_glBindTexture)(GLenum target, GLuint texture);
 void (*epoxy_glBlitFramebuffer)(GLint srcX0,
                                 GLint srcY0,
@@ -553,14 +591,26 @@ GLuint (*epoxy_glCreateShader)(GLenum shaderType);
 void (*epoxy_glDeleteFramebuffers)(GLsizei n, const GLuint* framebuffers);
 void (*expoxy_glDeleteShader)(GLuint shader);
 void (*epoxy_glDeleteTextures)(GLsizei n, const GLuint* textures);
+void (*epoxy_glFramebufferRenderbuffer)(GLenum target,
+                                        GLenum attachment,
+                                        GLenum renderbuffertarget,
+                                        GLuint renderbuffer);
 void (*epoxy_glFramebufferTexture2D)(GLenum target,
                                      GLenum attachment,
                                      GLenum textarget,
                                      GLuint texture,
                                      GLint level);
+void (*epoxy_glGetFramebufferAttachmentParameteriv)(GLenum target,
+                                                    GLenum attachment,
+                                                    GLenum pname,
+                                                    GLint* params);
 void (*epoxy_glGenFramebuffers)(GLsizei n, GLuint* framebuffers);
 void (*epoxy_glGenTextures)(GLsizei n, GLuint* textures);
 void (*epoxy_glLinkProgram)(GLuint program);
+void (*epoxy_glRenderbufferStorage)(GLenum target,
+                                    GLenum internalformat,
+                                    GLsizei width,
+                                    GLsizei height);
 void (*epoxy_glShaderSource)(GLuint shader,
                              GLsizei count,
                              const GLchar* const* string,
@@ -595,6 +645,7 @@ static void library_init() {
 
   epoxy_glAttachShader = _glAttachShader;
   epoxy_glBindFramebuffer = _glBindFramebuffer;
+  epoxy_glBindRenderbuffer = _glBindRenderbuffer;
   epoxy_glBindTexture = _glBindTexture;
   epoxy_glBlitFramebuffer = _glBlitFramebuffer;
   epoxy_glCompileShader = _glCompileShader;
@@ -604,16 +655,21 @@ static void library_init() {
   epoxy_glDeleteFramebuffers = _glDeleteFramebuffers;
   epoxy_glDeleteShader = _glDeleteShader;
   epoxy_glDeleteTextures = _glDeleteTextures;
+  epoxy_glFramebufferRenderbuffer = _glFramebufferRenderbuffer;
   epoxy_glFramebufferTexture2D = _glFramebufferTexture2D;
   epoxy_glGenFramebuffers = _glGenFramebuffers;
+  epoxy_glGenRenderbuffers = _glGenRenderbuffers;
   epoxy_glGenTextures = _glGenTextures;
+  epoxy_glGetFramebufferAttachmentParameteriv =
+      _glGetFramebufferAttachmentParameteriv;
   epoxy_glGetIntegerv = _glGetIntegerv;
   epoxy_glGetProgramiv = _glGetProgramiv;
   epoxy_glGetProgramInfoLog = _glGetProgramInfoLog;
   epoxy_glGetShaderiv = _glGetShaderiv;
   epoxy_glGetShaderInfoLog = _glGetShaderInfoLog;
   epoxy_glGetString = _glGetString;
   epoxy_glLinkProgram = _glLinkProgram;
+  epoxy_glRenderbufferStorage = _glRenderbufferStorage;
   epoxy_glShaderSource = _glShaderSource;
   epoxy_glTexParameterf = _glTexParameterf;
   epoxy_glTexParameteri = _glTexParameteri;