-
Notifications
You must be signed in to change notification settings - Fork 6k
[engine] force semantics action to post a task. #56514
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
| } | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wired up a test to verify this behavior but found that it was passing anyway. I don't know if this is due to the test environment, but 🤷♂️
|
auto label is removed for flutter/engine/56514, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…to semantics_action
…to semantics_action
|
auto label is removed for flutter/engine/56514, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…158551) flutter/engine@ef760d6...05c14d8 2024-11-13 [email protected] Roll Dart SDK from 5f42ef8f15d5 to c7d140d18895 (2 revisions) (flutter/engine#56552) 2024-11-13 [email protected] [engine] force semantics action to post a task. (flutter/engine#56514) 2024-11-13 [email protected] [Impeller] Wrap provided FBO instead of defaulting to FBO0 and cleanup/document the texture API. (flutter/engine#56543) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Repro:
Testing WIP.
b/373761573
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const Example());
}
class Example extends StatefulWidget {
const Example({super.key});
@OverRide
State<Example> createState() => _ExampleState();
}
class _ExampleState extends State<Example> {
bool value = true;
@OverRide
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: Center(
child: Semantics(
child: Text(
value ? 'Hello, world!' : 'Goodbye, World!',
),
button: true,
onTap: () async {
await null;
setState(() {
value = !value;
});
},
),
),
),
);
}
}
```
Repro:
Testing WIP.
b/373761573