This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Wrap provided FBO instead of defaulting to FBO0 and cleanup/document the texture API. #56543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @lyceel |
Member
jason-simmons
left a comment
jason-simmons
left a comment
There was a problem hiding this comment.
LGTM
The Linux embedder needs to be updated with changes similar to those made in surface_gles.cc
jason-simmons
approved these changes
Nov 12, 2024
…p/document the texture API. Previously, the FBO argument was dropped on the floor. The API was also confusing as the Android subsystems were using the IsWrapped call to sidestep texture contents initialization without actually performing any wrapping. Not, there are separate and documented calls to wrap a texture, wrap a framebuffer (as a texture), and to create a placeholder texture. Callers can also mark any texture as being initialized out of band instead of depending on overloading the meaning of IsWrapped. Fixes flutter/flutter#158486
chinmaygarde
force-pushed
the
dropfbo
branch
from
dc7a382 to
5bc3707
Compare
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2024
…and cleanup/document the texture API. (flutter/engine#56543)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2024
…and cleanup/document the texture API. (flutter/engine#56543)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 13, 2024
…158551) flutter/engine@ef760d6...05c14d8 2024-11-13 [email protected] Roll Dart SDK from 5f42ef8f15d5 to c7d140d18895 (2 revisions) (flutter/engine#56552) 2024-11-13 [email protected] [engine] force semantics action to post a task. (flutter/engine#56514) 2024-11-13 [email protected] [Impeller] Wrap provided FBO instead of defaulting to FBO0 and cleanup/document the texture API. (flutter/engine#56543) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…p/document the texture API. (flutter/engine#56543) Previously, the FBO argument was dropped on the floor. The API was also confusing as the Android subsystems were using the IsWrapped call to sidestep texture contents initialization without actually performing any wrapping. Now, there are separate and documented calls to wrap a texture, wrap a framebuffer (as a texture), and to create a placeholder texture. Callers can also mark any texture as being initialized out of band instead of depending on overloading the meaning of IsWrapped. Fixes flutter#158486
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the FBO argument was dropped on the floor.
The API was also confusing as the Android subsystems were using the IsWrapped call to sidestep texture contents initialization without actually performing any wrapping.
Now, there are separate and documented calls to wrap a texture, wrap a framebuffer (as a texture), and to create a placeholder texture.
Callers can also mark any texture as being initialized out of band instead of depending on overloading the meaning of IsWrapped.
Fixes flutter/flutter#158486