fixes mask blurs on stoked gradient geometry #55717
Conversation
|
Mostly look good. This one looks particularly wrong. But based on the name there should be some clipping somewhere and the reference image doesn't seem to have any. 
|
|
goldens are looking good now: https://flutter-engine-gold.skia.org/search?issue=55717&crs=github&patchsets=10&corpus=flutter-engine |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
can you update the bug description with what this changes?
You mean the PR's description? Done. Jonah did you see that the lines for the test don't render on opengl? That's kind of surprising. I'm not sure if we have that captured somewhere in an issue. |
I did not, which goldens are those? |
There is a white crosshair in the middle of the shape in vulkan and metal. 
|
|
hmm, don't know what that would be. File a bug? |
|
…156443) flutter/engine@0e7344a...db0c0b7 2024-10-08 [email protected] fixes mask blurs on stoked gradient geometry (flutter/engine#55717) 2024-10-08 [email protected] [Impeller] Do not scale the miter limit applied to stroked text (flutter/engine#55745) 2024-10-08 [email protected] Added support to set primitive type (flutter/engine#55514) 2024-10-08 [email protected] Roll Skia from 8a2fe88d31e3 to 701b6e4b4bc4 (1 revision) (flutter/engine#55752) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fixes flutter#155930 This starts taking into account the translation of the entity that is snapshotted when performing the gaussian blur. I'm uncertain under what conditions, but sometimes the snapshot logic would need this offset. The linked issue and added tests demonstrate those cases. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
2 participants
fixes flutter/flutter#155930
This starts taking into account the translation of the entity that is snapshotted when performing the gaussian blur. I'm uncertain under what conditions, but sometimes the snapshot logic would need this offset. The linked issue and added tests demonstrate those cases.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.