[Flutter GPU] Added support to set primitive type #55514
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@AthulJoseph27 We won't be able to take a look at this till you address the CLA bots request. Thanks. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Golden file changes are available for triage from new commit, Click here to view. |
|
Any update on the CLA bot request? |
|
auto label is removed for flutter/engine/55514, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
auto-submit
bot
removed
the
autosubmit
chinmaygarde
added
the
autosubmit
…156443) flutter/engine@0e7344a...db0c0b7 2024-10-08 [email protected] fixes mask blurs on stoked gradient geometry (flutter/engine#55717) 2024-10-08 [email protected] [Impeller] Do not scale the miter limit applied to stroked text (flutter/engine#55745) 2024-10-08 [email protected] Added support to set primitive type (flutter/engine#55514) 2024-10-08 [email protected] Roll Skia from 8a2fe88d31e3 to 701b6e4b4bc4 (1 revision) (flutter/engine#55752) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bdero
changed the title
Added a way to specify the PrimitiveType when encoding commands in the RenderPass. This partially fixes the issue flutter#142732
3 participants
Added a way to specify the PrimitiveType when encoding commands in the RenderPass.
This partially fixes the issue #142732