This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Drop deprecated hash_code functions (#54000)" #54002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ea1e53a.
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Jul 19, 2024
auto-submit
bot
deleted the
revert_ea1e53a4e8103960e1a74011887e9c16ce327411
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 19, 2024
…152018) flutter/engine@ea1e53a...969fb7a 2024-07-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Drop deprecated hash_code functions (#54000)" (flutter/engine#54002) 2024-07-19 [email protected] Upgrade third_party/pyyaml to 03c67afd452cdff45b41bfe65e19a2fb5b80a0e8 (flutter/engine#54001) 2024-07-19 [email protected] Don't leak binary messenger in tests (flutter/engine#53985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
kevmoo
added
the
revert
Contributor
Author
|
A reason for requesting a revert of flutter/engine/54002 could |
auto-submit
bot
removed
the
revert
Contributor
|
Reason for revert: the issue in google 3 has been fixed. |
kevmoo
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Jul 19, 2024
…)" (#54004) Reverts: #54002 Initiated by: kevmoo Reason for reverting: the issue in google 3 has been fixed. Original PR Author: auto-submit[bot] Reviewed By: {fluttergithubbot} This change reverts the following previous change: Reverts: #54000 Initiated by: chingjun Reason for reverting: Broke Google Testing. See b/352191023 for more details. Original PR Author: kevmoo Reviewed By: {jonahwilliams} This change reverts the following previous change: Fixes flutter/flutter#151679
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152018) flutter/engine@ea1e53a...969fb7a 2024-07-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Drop deprecated hash_code functions (flutter#54000)" (flutter/engine#54002) 2024-07-19 [email protected] Upgrade third_party/pyyaml to 03c67afd452cdff45b41bfe65e19a2fb5b80a0e8 (flutter/engine#54001) 2024-07-19 [email protected] Don't leak binary messenger in tests (flutter/engine#53985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152018) flutter/engine@ea1e53a...969fb7a 2024-07-19 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Drop deprecated hash_code functions (flutter#54000)" (flutter/engine#54002) 2024-07-19 [email protected] Upgrade third_party/pyyaml to 03c67afd452cdff45b41bfe65e19a2fb5b80a0e8 (flutter/engine#54001) 2024-07-19 [email protected] Don't leak binary messenger in tests (flutter/engine#53985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #54000
Initiated by: chingjun
Reason for reverting: Broke Google Testing.
See b/352191023 for more details.
Original PR Author: kevmoo
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
Fixes flutter/flutter#151679