Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jul 19, 2024

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Jul 19, 2024
@kevmoo kevmoo requested review from jonahwilliams and yjbanov July 19, 2024 01:25
@kevmoo
Copy link
Contributor Author

kevmoo commented Jul 19, 2024

Relanding

#53783
#53787

after revert

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2024
@auto-submit auto-submit bot merged commit ea1e53a into main Jul 19, 2024
@auto-submit auto-submit bot deleted the drop_deprecated_hash_functions branch July 19, 2024 02:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 19, 2024
…152012)

flutter/engine@b65c93e...ea1e53a

2024-07-19 [email protected] Drop deprecated hash_code functions (flutter/engine#54000)
2024-07-19 [email protected] Renamed plugin classes to handler (flutter/engine#53736)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@chingjun
Copy link
Contributor

Reason for revert: Broke Google Testing.

See b/352191023 for more details.

@chingjun chingjun added the revert Label used to revert changes in a closed and merged pull request. label Jul 19, 2024
auto-submit bot pushed a commit that referenced this pull request Jul 19, 2024
@auto-submit auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Jul 19, 2024
auto-submit bot added a commit that referenced this pull request Jul 19, 2024
Reverts: #54000
Initiated by: chingjun
Reason for reverting: Broke Google Testing.

See b/352191023 for more details.
Original PR Author: kevmoo

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
Fixes flutter/flutter#151679
auto-submit bot pushed a commit that referenced this pull request Jul 19, 2024
auto-submit bot added a commit that referenced this pull request Jul 19, 2024
…)" (#54004)

Reverts: #54002
Initiated by: kevmoo
Reason for reverting: the issue in google 3 has been fixed.
Original PR Author: auto-submit[bot]

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
Reverts: #54000
Initiated by: chingjun
Reason for reverting: Broke Google Testing.

See b/352191023 for more details.
Original PR Author: kevmoo

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
Fixes flutter/flutter#151679
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…lutter#152012)

flutter/engine@b65c93e...ea1e53a

2024-07-19 [email protected] Drop deprecated hash_code functions (flutter/engine#54000)
2024-07-19 [email protected] Renamed plugin classes to handler (flutter/engine#53736)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#152012)

flutter/engine@b65c93e...ea1e53a

2024-07-19 [email protected] Drop deprecated hash_code functions (flutter/engine#54000)
2024-07-19 [email protected] Renamed plugin classes to handler (flutter/engine#53736)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete deprecated hash functions

4 participants