[Impeller] Validation logs indicate where in code the validation error happened. #53784
Conversation
…r happened. Earlier, all validation logs originated from validation.cc which was not useful at all since you had to find the string in the source.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
added
the
autosubmit
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
Ah yeah, this is really useful, thanks. : )
…ation error happened. (flutter/engine#53784)
…151505) flutter/engine@9d943eb...371db85 2024-07-09 [email protected] [Impeller] Validation logs indicate where in code the validation error happened. (flutter/engine#53784) 2024-07-09 [email protected] Roll Fuchsia Linux SDK from yYs6rINJxWJ8J2vxo... to SrAow18WmBW8IDjza... (flutter/engine#53785) 2024-07-09 [email protected] web_ui: drop internal hash code library (flutter/engine#53783) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from yYs6rINJxWJ8 to SrAow18WmBW8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
Earlier, all validation logs originated from validation.cc which was not useful at all since you had to find the string in the source.