This repository was archived by the owner on Feb 25, 2025. It is now read-only.
web_ui: drop internal hash code library #53783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We moved to dart:core Object functions a while ago
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/engine/53783, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 10, 2024
…151505) flutter/engine@9d943eb...371db85 2024-07-09 [email protected] [Impeller] Validation logs indicate where in code the validation error happened. (flutter/engine#53784) 2024-07-09 [email protected] Roll Fuchsia Linux SDK from yYs6rINJxWJ8J2vxo... to SrAow18WmBW8IDjza... (flutter/engine#53785) 2024-07-09 [email protected] web_ui: drop internal hash code library (flutter/engine#53783) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from yYs6rINJxWJ8 to SrAow18WmBW8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
|
Reason for revert: There are still internal users of these hash functions (b/352191023). Flutter also exports it here so its easy for developers to use them even without importing |
jiahaog
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 10, 2024
This reverts commit d01bd52.
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Jul 10, 2024
Reverts: #53783 Initiated by: jiahaog Reason for reverting: There are still internal users of these hash functions (b/352191023). Flutter also exports it [here](https://github.com/flutter/flutter/blob/72f83d3237a051a8b1b849abd267d4a4e80ff774/packages/flutter/lib/src/painting/basic_types.dart#L58) so its easy for developers to use them even without importing `dart:ui`. Though it's an easy fix, I'd imagine this to be a breaking change for the OSS ecosystem a Original PR Author: kevmoo Reviewed By: {yjbanov} This change reverts the following previous change: We moved to dart:core Object functions a while ago
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved to dart:core Object functions a while ago