This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Renamed plugin classes to handler #53736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the naming used in the other embedders and removes the confusion between this and Flutter plugins.
This matches the naming used in the other embedders and removes the confusion between this and Flutter plugins.
This matches the naming used in the other embedders and removes the confusion between this and Flutter plugins.
loic-sharma
approved these changes
Jul 8, 2024
cbracken
approved these changes
Jul 9, 2024
Contributor
Author
|
Still looking into the test failure. It's an ASAN issue, i.e. a leak. |
Member
|
For the LSAN issue: this line in the suppression file needs to be updated to https://github.com/flutter/engine/blob/main/testing/lsan_suppressions.txt#L54 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 19, 2024
…152012) flutter/engine@b65c93e...ea1e53a 2024-07-19 [email protected] Drop deprecated hash_code functions (flutter/engine#54000) 2024-07-19 [email protected] Renamed plugin classes to handler (flutter/engine#53736) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152012) flutter/engine@b65c93e...ea1e53a 2024-07-19 [email protected] Drop deprecated hash_code functions (flutter/engine#54000) 2024-07-19 [email protected] Renamed plugin classes to handler (flutter/engine#53736) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152012) flutter/engine@b65c93e...ea1e53a 2024-07-19 [email protected] Drop deprecated hash_code functions (flutter/engine#54000) 2024-07-19 [email protected] Renamed plugin classes to handler (flutter/engine#53736) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux embedder had a number of handlers for Flutter channels that were named plugin/handler/manager. Rename these all to handler to be consistent and reduce confusion with Flutter plugins (which these don't use the infrastructure for).
Handler seemed to be the more common term looking at other embedders like Windows, but even there it's not used consistently. Open to other terms.