Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@christopherfujino
Copy link
Contributor

________ running 'cipd ensure -log-level info -root C:\b\s\w\ir\cache\builder -ensure-file C:\b\s\w\ir\x\t\tmpqrmxhpug.ensure' in '.'
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it
Error: Command 'cipd ensure -log-level info -root C:\\b\\s\\w\\ir\\cache\\builder -ensure-file C:\\b\\s\\w\\ir\\x\\t\\tmpqrmxhpug.ensure' returned non-zero exit status 1
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it

I think we messed up and created duplicate tags

@christopherfujino
Copy link
Contributor

________ running 'cipd ensure -log-level info -root C:\b\s\w\ir\cache\builder -ensure-file C:\b\s\w\ir\x\t\tmpqrmxhpug.ensure' in '.'
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it
Error: Command 'cipd ensure -log-level info -root C:\\b\\s\\w\\ir\\cache\\builder -ensure-file C:\\b\\s\\w\\ir\\x\\t\\tmpqrmxhpug.ensure' returned non-zero exit status 1
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it

I think we messed up and created duplicate tags

Filing a tracking issue for this: flutter/flutter#151206

@christopherfujino
Copy link
Contributor

________ running 'cipd ensure -log-level info -root C:\b\s\w\ir\cache\builder -ensure-file C:\b\s\w\ir\x\t\tmpqrmxhpug.ensure' in '.'
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it
Error: Command 'cipd ensure -log-level info -root C:\\b\\s\\w\\ir\\cache\\builder -ensure-file C:\\b\\s\\w\\ir\\x\\t\\tmpqrmxhpug.ensure' returned non-zero exit status 1
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it

I think we messed up and created duplicate tags

Filing a tracking issue for this: flutter/flutter#151206

I removed the tag from https://chrome-infra-packages.appspot.com/p/flutter/dart-sdk/windows-arm64/+/Yl9L7nIDSTcAgDFj9Q7Ce8jggdMszxCVHDT9hYMwoCMC, and have re-scheduled the windows presubmits

…nditional imports (flutter#53307)

Users of packages that have specialized code for the VM (which supports
FFI) use conditional imports based on `dart.library.ffi`. We don't want
the VM-specific code to be used for web in dart2wasm.

As a result we're going to make `dart.library.ffi` be false in
conditional imports (as well as in
`const bool.fromEnvironment('dart.library.ffi')`).

Issue dart-lang/sdk#55948
Issue flutter/flutter#149984
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Jul 10, 2024
@christopherfujino
Copy link
Contributor

eyebrowsoffire and others added 2 commits July 11, 2024 16:13
…er#53304)

The issue in [0] was fixed. So we no longer have to use conditional
imports and dart2wasm vs dart2js specific implementations.

Instead we use the new extension methods introduced due to [0], namely
`Object.toExternalReference` and `ExternalDartReference.toDartObject`.

[0] dart-lang/sdk#55183
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #53686 at sha 133e8a8

@christopherfujino
Copy link
Contributor

christopherfujino commented Jul 12, 2024

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #53686 at sha 133e8a8

To work around this, I pushed a commit (2bebada) deleting the impeller tests (I don't believe we ever ran golden tests on this branch previously), similar to this change on the 3.23 branch: #53178

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-web Code specifically for the web engine will affect goldens

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants