-
Notifications
You must be signed in to change notification settings - Fork 6k
[flutter_releases] beta 3.23 release engine - actually delete impeller tests #53178
[flutter_releases] beta 3.23 release engine - actually delete impeller tests #53178
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
@gaaclarke please double check my work here |
| "--variant", | ||
| "ci/host_release", | ||
| "--type", | ||
| "dart,dart-host,engine" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That name seems incorrect, it's a copy paste bug since impeller golden is listed in the name, but isn't listed in the --type argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, good catch, these seem like tests we want to run :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaaclarke restored this diff, PTAL
gaaclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
auto label is removed for flutter/engine/53178, due to - The status or check suite Linux linux_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Looks like network flake on linux_android_aot_engine: Triggering re-run |
This is a follow up to #53163, where I deleted the ninja target to build the golden tests, however I forgot to delete the commands to actually run the tests. In post-submit, the tests ran again and failed: https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20Production%20Engine%20Drone/12733/infra
This PR actually deletes the scripts to run the tests.