This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] enable always_specify_types for web_ui #53226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Jun 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 5, 2024
…149770) flutter/engine@11a32d4...f377330 2024-06-05 [email protected] Roll Skia from 37755d48cca3 to 8448abc95867 (7 revisions) (flutter/engine#53230) 2024-06-05 [email protected] Roll Dart SDK from dac7c04c7342 to f838a9a8d45f (3 revisions) (flutter/engine#53225) 2024-06-05 [email protected] Roll Skia from 337c3c4d1f1b to 37755d48cca3 (45 revisions) (flutter/engine#53224) 2024-06-05 [email protected] [web] enable always_specify_types for web_ui (flutter/engine#53226) 2024-06-05 [email protected] Re-land #52859: Revamp the engine style guide, remove `always_specify_types` (flutter/engine#53223) 2024-06-05 [email protected] Roll Fuchsia Linux SDK from pagJoGS4kQ8Efa_if... to 2xWubo2mRP_2_wXKJ... (flutter/engine#53222) 2024-06-05 [email protected] [icu] Manual roll of icu (flutter/engine#53199) 2024-06-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering (#53072)" (flutter/engine#53220) 2024-06-05 [email protected] [ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering (flutter/engine#53072) 2024-06-05 [email protected] Roll Dart SDK from 343c20614708 to dac7c04c7342 (1 revision) (flutter/engine#53209) 2024-06-04 [email protected] [Impeller] Intel iOS Simulators must block on GPU completion. (flutter/engine#53073) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from pagJoGS4kQ8E to 2xWubo2mRP_2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always_specify_types: falseandavoid_dynamic_calls: falseis a dangerous combination. Let's clean upavoid_dynamic_callsbefore disablingalways_specify_types.