Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Jun 5, 2024

Reverts: #53072

Initiated by: jason-simmons

Reason for reverting: compilation errors on iOS targets

FlutterPlatformViews_Internal.mm:277:10: error: ARC forbids explicit message send of 'dealloc'
  277 |   [super dealloc];
      |    ~~~~~ ^

(see https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8746006425774972161/+/u/build_ci_ios_debug_unopt_sim_flutter_testing_scenario_app_flutter_shell_platform_darwin_ios:ios_test_flutter/st

Original PR Author: hellohuanlin

Reviewed By: {cbracken, jonahwilliams}

This change reverts the following previous change:
This PR uses CAShapeLayer as the mask to avoid software rendering.

I kept UIView as the mask, so that we can measure just the improvement related to avoiding software rendering. This also allows me to land this change sooner. I created a separate issue to track removing UIView as the mask.

Note: the previous behavior seems to be incorrect (or at least not pixel perfect). This PR fixed it. See comments.

See design doc: https://docs.google.com/document/d/1TqG_N4GK_qctuk73Gk3zOdAiILUrwMqxoCMgroK_AeA/edit?resourcekey=0-jUiidfzIS642ngG2w9vSUA&tab=t.0

List which issues are fixed by this PR. You must list at least one issue.

Fixes flutter/flutter#142813
Fixes flutter/flutter#142830

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Jun 5, 2024
@auto-submit auto-submit bot merged commit 40d7aaa into main Jun 5, 2024
@auto-submit auto-submit bot deleted the revert_1314faf00cb9ab0234531dc63a281d07f1d861dc branch June 5, 2024 14:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 5, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 5, 2024
…149770)

flutter/engine@11a32d4...f377330

2024-06-05 [email protected] Roll Skia from 37755d48cca3 to 8448abc95867 (7 revisions) (flutter/engine#53230)
2024-06-05 [email protected] Roll Dart SDK from dac7c04c7342 to f838a9a8d45f (3 revisions) (flutter/engine#53225)
2024-06-05 [email protected] Roll Skia from 337c3c4d1f1b to 37755d48cca3 (45 revisions) (flutter/engine#53224)
2024-06-05 [email protected] [web] enable always_specify_types for web_ui (flutter/engine#53226)
2024-06-05 [email protected] Re-land #52859: Revamp the engine style guide, remove `always_specify_types` (flutter/engine#53223)
2024-06-05 [email protected] Roll Fuchsia Linux SDK from pagJoGS4kQ8Efa_if... to 2xWubo2mRP_2_wXKJ... (flutter/engine#53222)
2024-06-05 [email protected] [icu] Manual roll of icu (flutter/engine#53199)
2024-06-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering  (#53072)" (flutter/engine#53220)
2024-06-05 [email protected] [ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering  (flutter/engine#53072)
2024-06-05 [email protected] Roll Dart SDK from 343c20614708 to dac7c04c7342 (1 revision) (flutter/engine#53209)
2024-06-04 [email protected] [Impeller] Intel iOS Simulators must block on GPU completion. (flutter/engine#53073)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from pagJoGS4kQ8E to 2xWubo2mRP_2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-ios revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
2 participants