This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Revamp the engine style guide, remove always_specify_types. (#52859)"
#52867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
May 16, 2024
auto-submit
bot
deleted the
revert_e6e37b4a9bdfa5501d2270c6d70a3375526fa317
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 16, 2024
…148455) flutter/engine@942d7c3...9e17588 2024-05-16 [email protected] `et` generates `{out}/{buildName}` if missing on `et {build|test|query}` (flutter/engine#52866) 2024-05-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Revamp the engine style guide, remove `always_specify_types`. (#52859)" (flutter/engine#52867) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #52859
Initiated by: zanderso
Reason for reverting: This sort of change is in scope for a discussion at the Dash forum.
Original PR Author: matanlurey
Reviewed By: {cbracken, gaaclarke, johnmccutchan}
This change reverts the following previous change:
Based on the (internal) discussion around converging on using the official Dart style guide, with the exception of the code that gets published under
dart:ui, as that is user-facing, and we'd like to evolve the code style in conjunction with the framework.I also took the opportunity to specify more about our style guide use in general, mostly to make it easier to understand our conventions, and also call out known problem areas (notably, our over-use of
shared_ptrandautoin some cases). I am happy to split those up, but it was easier to make the markdown changes at once.I also took @cbracken and folks advice and clarified directly that explicit types in Dart are not bad (with examples).